From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 613871F66F for ; Tue, 3 Nov 2020 22:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729921AbgKCWCz (ORCPT ); Tue, 3 Nov 2020 17:02:55 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:54569 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729860AbgKCWCp (ORCPT ); Tue, 3 Nov 2020 17:02:45 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6571BE5A4D; Tue, 3 Nov 2020 17:02:43 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=6Ubv2epFbZuuR0dIGaChoGJ6QBg=; b=HiFqUD izdsuMUrhywvQHgx20+Y4QVcadW1Fec+sCRm1Qp9bZ/ms+eXPAVkrrL7WUh5u8Md QeqHzZq6F6Lp2ZHvP39f/TGQFOH5ApboLt8OY/SeuszYapp7C3dt/LauMxrfLv9z EhbdLg8qUkWP10KwGWxr0dv2I8J3Pm88HJ/5w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=CP4UuGn/MN2OLzgPyfiKbHRTyJMjFJ8N W1QOvGunzmDktCCkGFoE5yI826c4CmMyLo6zb0y/S3CkRB3WTRhUoDRoa/gYEkiE bXU4Ow8xRmTwSqGd4TAlfw4Im/iyVU0rh1+geTS/uxxg/iOyZgx8KdLyISAAOzgx 9u/3LgqRxb4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5D652E5A4C; Tue, 3 Nov 2020 17:02:43 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 8C8B5E5A4B; Tue, 3 Nov 2020 17:02:40 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Johannes Schindelin via GitGitGadget" Cc: git@vger.kernel.org, "Chris. Webster" , Johannes Schindelin Subject: Re: [PATCH] ci: make the whitespace checker more robust References: Date: Tue, 03 Nov 2020 14:02:38 -0800 In-Reply-To: (Johannes Schindelin via GitGitGadget's message of "Tue, 03 Nov 2020 15:55:31 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 4AB27760-1E20-11EB-90F0-E43E2BB96649-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Johannes Schindelin via GitGitGadget" writes: > One thing we discussed earlier whether the log should be pasted as > pre-formatted text or not, and we fell on the side of not pre-formatting > it. However, in my tests, this does not look right > [https://github.com/dscho/git/pull/18#issuecomment-721160985], and it > looks much better pre-formatted > [https://github.com/dscho/git/pull/18#issuecomment-721167209] (even if > we unfortunately lose the direct link to the commit > [https://github.com/dscho/git/commit/68317764849af81b17c4b31906da20bdf2c52082] > ). What is shown in the log are lines from the source files that were checked, and we expect our source files are shown and edited in monospace with tabwidth=8, I think it does make sense to force the "pre-formatted" output. Thanks.