From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name
Date: Fri, 06 Nov 2020 09:53:53 -0800 [thread overview]
Message-ID: <xmqqsg9mfk26.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <ec59a5d8-26fc-988e-4458-fd2cd421f9d5@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 6 Nov 2020 02:39:10 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>> "make distclean" can still depend on GIT-VERSION-FILE and your daily
>> cleaning needs can use "make clean" that cleans only the files that
>> can be cleaned without knowing what GIT_VERSION is, no? That way,
>> we do not have to use dist-tars file at all, no?
>
> Hmm, so rather than dropping the last two patches, you are suggesting
> replacing this patch with a patch that moves:
>
> $(RM) $(GIT_TARNAME).tar.gz
> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>
> to the 'distclean' target?
Yup. FWIW, I consider it a feature that
for m in maint-2.{27,28,29}
do
git checkout "$m" &&
make distclean &&
make dist || break
do
gives me three distribution tarballs of from-scratch builds. It
matters when I need to push out releases from multiple maintenance
tracks at the same time (think: coordinated security releases).
I could of course move them away before running distclean in each
step, but then I'd be following a different workflow from what I
normally use when cutting a single release---I would rather avoid
deviating from the routine when I have to be absolutely careful
(again, think: coordinated security releases).
> Well, that would address your concerns, but I was hoping to fix the
> 'your current branch has to be the same as the one you created the
> tarballs on' for the '(dist)clean' target to actually remove those
> files issue.
So we on this part have directly opposing wish, unfortunately.
next prev parent reply other threads:[~2020-11-06 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 21:09 [PATCH 7/8] Makefile: don't delete dist tarballs directly by name Ramsay Jones
2020-11-05 22:01 ` Junio C Hamano
2020-11-05 23:05 ` Junio C Hamano
2020-11-06 1:44 ` Ramsay Jones
2020-11-06 1:58 ` Junio C Hamano
2020-11-06 2:39 ` Ramsay Jones
2020-11-06 17:53 ` Junio C Hamano [this message]
2020-11-06 20:23 ` Ramsay Jones
2020-11-06 1:36 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg9mfk26.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).