From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: "Rafael Silva" <rafaeloliveira.cs@gmail.com>,
git@vger.kernel.org, "Derrick Stolee" <dstolee@microsoft.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v2 1/1] maintenance: fix SEGFAULT when no repository
Date: Tue, 08 Dec 2020 13:58:49 -0800 [thread overview]
Message-ID: <xmqqsg8g559i.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201208201256.GK36751@google.com> (Josh Steadmon's message of "Tue, 8 Dec 2020 12:12:56 -0800")
Josh Steadmon <steadmon@google.com> writes:
> Caught a typo here, sending this as a squash patch since it's already in
> next:
The breakage and the fix looks obvious to me, but...
How did CI allow 'next' to pass with such a typo, I wonder?
Moreover, my pre-push tests of all the integration branches
I didn't notice this to fail, but I cannot see how it could
have been succeeded. Puzzled...
Will queue, thanks.
>
> -- >8 --
> Subject: [PATCH] t7900: fix typo: "test_execpt_success"
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> t/t7900-maintenance.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
> index 4ca3617173..8c061197a6 100755
> --- a/t/t7900-maintenance.sh
> +++ b/t/t7900-maintenance.sh
> @@ -441,7 +441,7 @@ test_expect_success 'register preserves existing strategy' '
> test_config maintenance.strategy incremental
> '
>
> -test_execpt_success 'fails when running outside of a repository' '
> +test_expect_success 'fails when running outside of a repository' '
> nongit test_must_fail git maintenance run &&
> nongit test_must_fail git maintenance stop &&
> nongit test_must_fail git maintenance start &&
next prev parent reply other threads:[~2020-12-08 22:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 16:44 [PATCH 0/1] maintenance: Fix a SEGFAULT when no repository when running git maintenance run/start Rafael Silva
2020-11-24 16:44 ` [PATCH 1/1] maintenance: fix a SEGFAULT when no repository Rafael Silva
2020-11-24 17:22 ` Derrick Stolee
2020-11-24 21:48 ` Junio C Hamano
2020-11-24 21:59 ` Derrick Stolee
2020-11-26 8:22 ` Rafael Silva
2020-11-26 11:21 ` Derrick Stolee
2020-11-24 17:24 ` Eric Sunshine
2020-11-24 19:14 ` SZEDER Gábor
2020-11-24 19:34 ` Eric Sunshine
2020-11-26 7:13 ` Rafael Silva
2020-11-24 19:03 ` Martin Ågren
2020-11-26 7:07 ` Rafael Silva
2020-11-26 20:41 ` [PATCH v2 0/1] maintenance: Fix SEGFAULT when running outside of a repository Rafael Silva
2020-11-26 20:41 ` [PATCH v2 1/1] maintenance: fix SEGFAULT when no repository Rafael Silva
2020-11-27 20:43 ` Derrick Stolee
2020-12-08 20:12 ` Josh Steadmon
2020-12-08 21:58 ` Junio C Hamano [this message]
2020-12-08 22:17 ` Junio C Hamano
2020-12-24 8:12 ` Christian Couder
2020-12-24 14:14 ` Junio C Hamano
2020-12-09 9:29 ` Rafael Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsg8g559i.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=pclouds@gmail.com \
--cc=rafaeloliveira.cs@gmail.com \
--cc=steadmon@google.com \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).