From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B13761F4B4 for ; Thu, 14 Jan 2021 07:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726677AbhANH1o (ORCPT ); Thu, 14 Jan 2021 02:27:44 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:64186 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbhANH1o (ORCPT ); Thu, 14 Jan 2021 02:27:44 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 89E58AA9E3; Thu, 14 Jan 2021 02:27:01 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=qIae8oEFjt0AjUPd/7H/ZKR1LHk=; b=bbh6oS d+u47vXfZnynyy1zNfPiqxpuANlf0WHE+fDTH0OE3DyBltMU8sZcwu0RgA02Gq5u NZPipG1/Kcim73BBxmJmhcyEyHqzJsVxclynnSwEGa8NYabSCfyoD+KjyaPcUIVS AfHiOKr6jKF+hq356zOaRtL8UfRAzsmv4BJOw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=tozZPGi7eaGKy1kMYnNRXAyGg+jpj5YZ kLfyiv1o7L/CxOgzVLFsAAx84wHnO9EN8+FiifMG7D50SQojOeLdaUyc7Qs4KZUU dk/i7+pLbV0U/r/biediEAbvHOSNicqd40otCj+ToBy0twjz8/4yX8depKSzcjlX LPWt/zc6Mik= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 22688AA9E1; Thu, 14 Jan 2021 02:27:01 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 71633AA9DF; Thu, 14 Jan 2021 02:27:00 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, jrnieder@gmail.com, peff@peff.net Subject: Re: [PATCH v2 1/8] packfile: prepare for the existence of '*.rev' files References: <6742c15c84bafbcc1c06e2633de51dcda63e3314.1610576805.git.me@ttaylorr.com> Date: Wed, 13 Jan 2021 23:26:59 -0800 In-Reply-To: <6742c15c84bafbcc1c06e2633de51dcda63e3314.1610576805.git.me@ttaylorr.com> (Taylor Blau's message of "Wed, 13 Jan 2021 17:28:06 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E4195094-5639-11EB-BA6F-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Taylor Blau writes: > Specify the format of the on-disk reverse index 'pack-*.rev' file, as > well as prepare the code for the existence of such files. We've changed the pack .idx file format once as the file format is versioned. I wonder if you considered placing the reverse index information in the same file, with version bump, in the .idx?