From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id BBC2B1F4B4 for ; Thu, 8 Apr 2021 07:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbhDHHdV (ORCPT ); Thu, 8 Apr 2021 03:33:21 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:60465 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbhDHHdU (ORCPT ); Thu, 8 Apr 2021 03:33:20 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id C055312AA05; Thu, 8 Apr 2021 03:33:09 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=oO7JZoNCcCsOcw6VMAGbuSHBg 1Q=; b=H7p8TApRS51MO9jKv0VgNZwMB203JaLoAXHLux+jhyz4qUgHPc63reKWS ckW8gtXMryoVw3O3ZAW45YYXCR3JWZZcOs8saJ+G0k6h/JHHZiTU4B1jY1f0ivYF ZWAC7erUseKoo06GV03MVDXowdLRau8VrqOH7wiVFooJW2I+4k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=sasl; b=tkjC3voQuiDiVXHtUz2 wGaBTBczIDnyYqLNLGSobZ3wVxZmVhhGCAgOPTHZXz9xz0v03VFXfDuzkxs8AFkx NWnzq7cC+CifK2gHB0vfha7F2HurT0nMxV/dR46OSl2TU9gxm8noupvYztfcu3or qlg3cyXe3PhOkzU1bU9fpp9Y= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B914B12AA04; Thu, 8 Apr 2021 03:33:09 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.243.138.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 1064712AA03; Thu, 8 Apr 2021 03:33:06 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Derrick Stolee , Derrick Stolee via GitGitGadget , git@vger.kernel.org, tom.saeger@oracle.com, sunshine@sunshineco.com, Derrick Stolee , Derrick Stolee Subject: Re: [PATCH 3/5] refspec: output a refspec item References: <87r1jmjxdg.fsf@evledraar.gmail.com> <87czv5kaxw.fsf@evledraar.gmail.com> <871rblk8ct.fsf@evledraar.gmail.com> Date: Thu, 08 Apr 2021 00:33:05 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: A94DA1F0-983C-11EB-BF71-E43E2BB96649-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > But yes, it seems even more straightforward to do away with passing the > refspec at all to "git fetch", and instead pass some (maybe internal > only, and documented as such) "--refspec-dst-prefix=3Drefs/prefetch/" > option to "git fetch". > > I.e. get_ref_map() over there is already doing a version of this loop > over "remote->fetch.nr". > > So instead of "git gc" doing the loop, then passing all the refspecs on > the command-line, it could tell "git fetch" to do the same munging when > it does the same iteration. That direction makes quite a lot of sense to me. > Doing the munging in builtin/gc.c's fetch_remote() just seems like a > relic from when we didn't care what decision builtin/fetch.c made about > refspecs, we always wanted our custom one.