From: Junio C Hamano <gitster@pobox.com>
To: Sergey Organov <sorganov@gmail.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Thomas Rast" <tr@thomasrast.ch>,
"Denton Liu" <liu.denton@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] stash: implement '--staged' option for 'push' and 'save'
Date: Fri, 15 Oct 2021 12:22:30 -0700 [thread overview]
Message-ID: <xmqqsfx25c09.fsf@gitster.g> (raw)
In-Reply-To: <87pms6cdnk.fsf@osv.gnss.ru> (Sergey Organov's message of "Fri, 15 Oct 2021 22:05:03 +0300")
Sergey Organov <sorganov@gmail.com> writes:
>> but
>> unlike the "stash -p" that goes interactive to let the user pick
>> hunks, in which context "oh, no, you did not SELECT anything" makes
>> perfect sense as an error message, this message would be confusing
>> to users who weren't offered a chance to select.
>
> It seems to me that it makes sense to leave this warning as is, in case
> the user invoked "stash --staged" without anything staged. I'm OK to
> change this if you have something better in mind.
I am not questioning the presense of the warning. It is just the
phrasing of the warning---"You have nothing staged" would make a
good message, but "You didn't select anything", when we do not offer
them a chance to select in the first place, would not work well.
next prev parent reply other threads:[~2021-10-15 19:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 22:12 [PATCH RFC] stash: implement '--staged' option for 'push' and 'save' Sergey Organov
2021-10-11 20:16 ` [PATCH RFC v1] " Sergey Organov
2021-10-11 21:21 ` Eric Sunshine
2021-10-11 21:55 ` Sergey Organov
2021-10-12 9:18 ` Ævar Arnfjörð Bjarmason
2021-10-12 11:20 ` Sergey Organov
2021-10-12 12:04 ` Junio C Hamano
2021-10-12 12:34 ` Junio C Hamano
2021-10-12 16:07 ` Sergey Organov
2021-10-12 17:28 ` Junio C Hamano
2021-10-12 18:25 ` Sergey Organov
2021-10-13 4:48 ` Junio C Hamano
2021-10-13 13:43 ` Sergey Organov
2021-10-15 15:04 ` [PATCH v2] " Sergey Organov
2021-10-15 17:58 ` Junio C Hamano
2021-10-15 19:05 ` Sergey Organov
2021-10-15 19:22 ` Junio C Hamano [this message]
2021-10-15 20:14 ` Sergey Organov
2021-10-15 20:21 ` Sergey Organov
2021-10-18 16:09 ` [PATCH v3] " Sergey Organov
2021-10-26 5:05 ` Jeff King
2021-10-27 15:11 ` Sergey Organov
2021-10-27 15:20 ` [PATCH v4] " Sergey Organov
2021-10-27 21:19 ` Junio C Hamano
2021-10-28 8:29 ` [PATCH] stash: get rid of unused argument in stash_staged() Sergey Organov
2021-10-28 21:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfx25c09.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=sorganov@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).