From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=1.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2475B1F670 for ; Sun, 20 Feb 2022 20:17:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244496AbiBTUQo (ORCPT ); Sun, 20 Feb 2022 15:16:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238792AbiBTUQn (ORCPT ); Sun, 20 Feb 2022 15:16:43 -0500 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A8E34C43F for ; Sun, 20 Feb 2022 12:16:22 -0800 (PST) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id AF0431799CA; Sun, 20 Feb 2022 15:16:21 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=8wymC2HFSWLs4eDiAztwVKX6Au9vM+v28i0EYU 4o/so=; b=MRWn3hOfWG9cMRoZJ6+8MyMDnh/ZgoSbkrqfQhItVXtx31ZxSm6n2U xoMFLa1Mxf2B6pqq6dDvksAnKhmXe+f/4Ii8ioN0dCYuI5zDf07Pss/Vz6AYDJfY frVKnEg9jdU0n9Y2kkqx8VYJz6ydeVWwGsLEyI0u0C3CnifcyVwHU= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A62D81799C9; Sun, 20 Feb 2022 15:16:21 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 0749D1799C8; Sun, 20 Feb 2022 15:16:19 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: Elijah Newren via GitGitGadget , git@vger.kernel.org, Jonathan Nieder , Jonathan Tan , jabolopes@google.com, Jeff Hostetler , Elijah Newren Subject: Re: [PATCH] Provide config option to expect files outside sparse patterns References: <54a0aa74-57c2-ee65-ae07-cb1b0daf947f@github.com> Date: Sun, 20 Feb 2022 12:16:18 -0800 In-Reply-To: <54a0aa74-57c2-ee65-ae07-cb1b0daf947f@github.com> (Derrick Stolee's message of "Sun, 20 Feb 2022 14:41:55 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F6CD0B44-9289-11EC-A781-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Derrick Stolee writes: > This patch looks like a good solution to the concerns brought up by > Jonathan N. around vfsd. VFS for Git uses the microsoft/git fork with > its own custom config to protect things like this. I imagine that we > will start setting your core_expect_files_outside_sparse_patterns > variable when reading the virtual filesystem info. We might even modify > some of our custom checks to use this variable instead. That would make > them appropriate to send upstream. > > Should we update Documentation/config/core.txt describing this config > key? Or is this intended to be an internal detail only for something > like vfsd? > > The only concern here really is if we want to be picky about the "VFS > for Git" references instead of "vfsd" references in the commit message. Thanks for a quick response to make sure what our left hand is trying to do will not interfere with what our right hand has already been doing ;-)