From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 36DB41F8C4 for ; Thu, 24 Mar 2022 17:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352151AbiCXRPN (ORCPT ); Thu, 24 Mar 2022 13:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346726AbiCXRPM (ORCPT ); Thu, 24 Mar 2022 13:15:12 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2855643B for ; Thu, 24 Mar 2022 10:13:39 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 7227C12B51E; Thu, 24 Mar 2022 13:13:38 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=28Lqc9PZul2iA1hA86K6Ln2FjgkD+sbHdNRIAD ZuVYg=; b=Uk2HzMBKInpzt4iTIo9GP/IZ8CN8Dlv/z7jy2sdhbD43LT2Cv0NH7V YoPVcd+KogHmh64WX4tf4EqA8JaybI1jsw6z0i1spt8DBn7BHbJ9qE7r+sF91l8G NuO4XcLRm/4U1izHQe4oFpW5gLAPUpUCNtqG8eDxyLjxAkFB2aPTM= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6883312B51D; Thu, 24 Mar 2022 13:13:38 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.227.145.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D34AB12B51C; Thu, 24 Mar 2022 13:13:37 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: Victoria Dye via GitGitGadget , git@vger.kernel.org, Victoria Dye , Derrick Stolee Subject: Re: [PATCH v2 0/3] reset: make --no-refresh the only way to skip index refresh References: <6d424915-5c63-bebd-f3b5-f153a541d077@gmail.com> Date: Thu, 24 Mar 2022 10:13:36 -0700 In-Reply-To: <6d424915-5c63-bebd-f3b5-f153a541d077@gmail.com> (Phillip Wood's message of "Thu, 24 Mar 2022 11:11:02 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: BEA8EC86-AB95-11EC-8675-CB998F0A682E-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Phillip Wood writes: > I should have been clearer in my comments that I think changing the > option name no '--no-refresh' whilst retaining '--refresh' is > worthwhile. '--no-refresh' is the form that users will want most of > the time and changing the option name means that the useful version > will be shown by "reset -h". I am OK with it shown as "--[no-]refresh" or even "--refresh" alone, as long as the description describes the "refresh" behaviour and makes it clear that it is the default, with the expectation that the users know from other boolean options that "--option" listed in "-h" would naturally take "--no-option". But as posted, $ rungit seen reset -h 2>&1 | grep refresh --refresh skip refreshing the index after reset the explanation given is for "--no-refresh" (which is wrong), so we'd need some fix in the area. We could rephrase it to read --refresh refresh the index after reset (default) but as you suggested, I think mimicking how existing commands with "--no-