From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id CD7F21F8C4 for ; Mon, 28 Mar 2022 16:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242407AbiC1QgZ (ORCPT ); Mon, 28 Mar 2022 12:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242380AbiC1QgY (ORCPT ); Mon, 28 Mar 2022 12:36:24 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FEBB1CFD7 for ; Mon, 28 Mar 2022 09:34:42 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 76AB912D588; Mon, 28 Mar 2022 12:34:41 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=uhXLt6IGIiGX MrlfEl/eNt34Zz6HCtEU8yA1BNExayg=; b=xVgZGI3CzILXGEpePMS6m2FQGZcD H2VaxSCx6uOOjJZ0fYtyByPqn0N69tD0fVVaH3q7mmhUdJTJtO2I+XaSt2nMzyTM G4M7DC1gAO6OmsGQ7ugGNqDYm/bCM2BN0tV25dOS3uXXZQy2klS/MtuxGgTz3k5D JKiu4DOZss1r4QI= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6E18612D587; Mon, 28 Mar 2022 12:34:41 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.227.145.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D276712D586; Mon, 28 Mar 2022 12:34:40 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Taylor Blau , SZEDER =?utf-8?Q?G=C3=A1bor?= , =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh , Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n?= , Johannes Schindelin , Victoria Dye , Matheus Tavares , Lars Schneider Subject: Re: [PATCH v2 00/25] CI: run "make [test]" directly, use $GITHUB_ENV References: Date: Mon, 28 Mar 2022 09:34:39 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 25 Mar 2022 19:37:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: F7592C4A-AEB4-11EC-8656-CB998F0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > A re-roll of my improvements my series to simplify the CI setup a lot > (see diffstat), much of it was dealing with constraints that went away > with Travis et al. CI for this series (OSX runners failing for > unrelated reasons): > > https://github.com/avar/git/actions/runs/2040223909 > > For a much more detailed summary of how the output looks before/after > see v1[]. > > This series heavily conflicts with Johannes's > js/ci-github-workflow-markup in "seen", but in the v1 I suggested > basing that series on top of this one, because it can benefit a lot > from these simplifications. > > I'll reply to this series with a proposed rebasing of that series on > top of this one, which allows for removing almost all of its changes > to "ci/" with no harm to its end-goals, i.e. the splitting up of > "make" and "make test" output is something it'll get for free from > this series. A sample run for this can be seen at https://github.com/git/git/runs/5715128999?check_suite_focus=3Dtrue With the output, I can point at a specific line, e.g. https://github.com/git/git/runs/5715128999?check_suite_focus=3Dtrue#ste= p:7:1150 The URLs with Dscho's one that correspond to the above two are https://github.com/git/git/runs/5699946885?check_suite_focus=3Dtrue https://github.com/git/git/runs/5699946885?check_suite_focus=3Dtrue#ste= p:4:1826 The specific breakage (which has little to do with the comparison between CI error pages) is that diff_setup() is called and populate diff_options.parseopts member but diff_setup_done() does not seem to be called and ends up leaking it. I wonder why options->parseopts is not freed immediately after diff_opt_parse() calls parse_options(), but need to be kept until diff_setup_done().