From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 4829E1F4D7 for ; Wed, 11 May 2022 23:07:29 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="xk1karo7"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348996AbiEKXHY (ORCPT ); Wed, 11 May 2022 19:07:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348992AbiEKXHW (ORCPT ); Wed, 11 May 2022 19:07:22 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59CD95839C for ; Wed, 11 May 2022 16:07:20 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 6E0E91979D1; Wed, 11 May 2022 19:07:19 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=GLqTWYxV17ReBsfgvAf0SzgIb+n9e0JK6hNUt6 /sIEg=; b=xk1karo7jeSD3se+QiDcxAELEB/ptOxtBG23FpA2X0q866TWJhSCDz mj4S4zoJouHDy1Coa4Wc+7p3zfHJlTGOeSgLvw9Kz7/WQV6Hhioa9/RJKc6WeIGL CnUMkrFzYNoykQCkUScCapXbihvgqWJBpY1r2MqeR7kgdvZf50TBE= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 6841B1979D0; Wed, 11 May 2022 19:07:19 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.65.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 1A8C51979CF; Wed, 11 May 2022 19:07:16 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Goss Geppert Cc: git@vger.kernel.org, christian w , Elijah Newren , Derrick Stolee Subject: Re: [PATCH v2 1/2] dir: consider worktree config in path recursion References: <20220505203234.21586-1-ggossdev@gmail.com> <20220510171527.25778-1-ggossdev@gmail.com> <20220510171527.25778-2-ggossdev@gmail.com> Date: Wed, 11 May 2022 16:07:14 -0700 In-Reply-To: <20220510171527.25778-2-ggossdev@gmail.com> (Goss Geppert's message of "Tue, 10 May 2022 17:15:26 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 198B353C-D17F-11EC-B2D9-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Goss Geppert writes: > Since 8d92fb2927 (dir: replace exponential algorithm with a linear one, > 2020-04-01) the following no longer works: > > 1) Initialize a repository. > 2) Set the `core.worktree` location to a parent directory of the > default worktree. > 3) Add a file located in the default worktree location to the index > (i.e. anywhere in the immediate parent directory of the gitdir). I think I've mentioned this ealier, but the above only describes the scenario and does not say what behaviour is expected and what behaviour is observed. "no longer works" is OK, but not sufficient. Easily remedied by saying "It used to do X, but now it does Y" after the above description of the scenario to describe what happens and what you want to happen. > + git --git-dir="test1/.git" config core.worktree "$(pwd)" && I wonder if this lets funny paths to be added to the index, e.g. would "git add test1" recursively add everything in that directory? Thanks.