From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 366A81F4D7 for ; Thu, 16 Jun 2022 16:50:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="DeJeJrwW"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbiFPQuh (ORCPT ); Thu, 16 Jun 2022 12:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbiFPQue (ORCPT ); Thu, 16 Jun 2022 12:50:34 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EB11B8A for ; Thu, 16 Jun 2022 09:50:33 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 717EC18F04B; Thu, 16 Jun 2022 12:50:32 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=2J28dyRJhqH4 iSJolEksxVw53bqvcQbrHuPAZdgw4Bg=; b=DeJeJrwWEFKe/Z/DKsS/ir3kh+J+ 7uIvfrSlJxZ8m6pf6upxkl2dXim2+Kci/+8y5nlFEUmLaLZ3xF1OH5xTUyFepOKY wDn7PLymQ8cTK8Du3UZViWyHuBQ743QHu56aH09HyvClNNU9ngXGb2AY32wnCNOB /FdoEHToVdMPWGI= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 693B518F04A; Thu, 16 Jun 2022 12:50:32 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 5E20318F049; Thu, 16 Jun 2022 12:50:28 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Michael J Gruber Cc: Johannes Schindelin , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH] t3701: two subtests are fixed References: <165537087609.19905.821171947957640468.git@grubix.eu> Date: Thu, 16 Jun 2022 09:50:27 -0700 In-Reply-To: <165537087609.19905.821171947957640468.git@grubix.eu> (Michael J. Gruber's message of "Thu, 16 Jun 2022 11:14:36 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 6D28FD92-ED94-11EC-829B-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Michael J Gruber writes: > Johannes Schindelin venit, vidit, dixit 2022-06-15 16:50:40: >> Hi Michael, > > Hallo Dscho! > >> On Tue, 14 Jun 2022, Michael J Gruber wrote: >>=20 >> > 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-1= 1-30) >> > switched to the implementation which fixed to subtest. Mark them as >> > expect_success now. >>=20 >> Good catch! > =20 > I'm no list regular anymore, but still a "next+ regular". While > experimenting with my own patch I noticed something got fixed > unexpectedly. That goes to show that these unexpected successes > (from expect_failure) go unnoticed too easily. I had missed this on my > regular rebuilds. Thanks for being a "next+ regular". They are giving us a valuable service to catch bugs and questionable design decisions before they hit the "master" branch. > =C3=86var noticed this and has a better version of my patch, I think. Yup. Eventually we will make it even impossible to opt out of the built-in variant, but until then, we'd need the conditional stuff. Thanks.