From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@grubix.eu>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t3701: two subtests are fixed
Date: Thu, 16 Jun 2022 09:50:27 -0700 [thread overview]
Message-ID: <xmqqsfo4v9gs.fsf@gitster.g> (raw)
In-Reply-To: <165537087609.19905.821171947957640468.git@grubix.eu> (Michael J. Gruber's message of "Thu, 16 Jun 2022 11:14:36 +0200")
Michael J Gruber <git@grubix.eu> writes:
> Johannes Schindelin venit, vidit, dixit 2022-06-15 16:50:40:
>> Hi Michael,
>
> Hallo Dscho!
>
>> On Tue, 14 Jun 2022, Michael J Gruber wrote:
>>
>> > 0527ccb1b5 ("add -i: default to the built-in implementation", 2021-11-30)
>> > switched to the implementation which fixed to subtest. Mark them as
>> > expect_success now.
>>
>> Good catch!
>
> I'm no list regular anymore, but still a "next+ regular". While
> experimenting with my own patch I noticed something got fixed
> unexpectedly. That goes to show that these unexpected successes
> (from expect_failure) go unnoticed too easily. I had missed this on my
> regular rebuilds.
Thanks for being a "next+ regular". They are giving us a valuable
service to catch bugs and questionable design decisions before they
hit the "master" branch.
> Ævar noticed this and has a better version of my patch, I think.
Yup. Eventually we will make it even impossible to opt out of the
built-in variant, but until then, we'd need the conditional stuff.
Thanks.
next prev parent reply other threads:[~2022-06-16 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 15:26 [PATCH] t3701: two subtests are fixed Michael J Gruber
2022-06-14 15:40 ` [PATCH v2] add -i tests: mark "TODO" depending on GIT_TEST_ADD_I_USE_BUILTIN Ævar Arnfjörð Bjarmason
2022-06-15 2:47 ` Todd Zullinger
2022-06-16 10:16 ` Ævar Arnfjörð Bjarmason
2022-06-16 13:47 ` Todd Zullinger
2022-06-14 15:48 ` [PATCH] t3701: two subtests are fixed Derrick Stolee
2022-06-15 1:25 ` Todd Zullinger
2022-06-15 1:55 ` Taylor Blau
2022-06-15 14:50 ` Johannes Schindelin
2022-06-16 9:14 ` Michael J Gruber
2022-06-16 16:50 ` Junio C Hamano [this message]
2022-06-18 11:55 ` Johannes Schindelin
2022-06-21 15:45 ` Junio C Hamano
2022-06-22 8:24 ` Michael J Gruber
2022-06-23 15:55 ` Johannes Schindelin
2022-06-23 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfo4v9gs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).