git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] help: reword explanation line for developer interfaces
@ 2022-09-16 13:05 Fangyi Zhou via GitGitGadget
  2022-09-16 16:19 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Fangyi Zhou via GitGitGadget @ 2022-09-16 13:05 UTC (permalink / raw)
  To: git; +Cc: Fangyi Zhou, Fangyi Zhou

From: Fangyi Zhou <me@fangyi.io>

Signed-off-by: Fangyi Zhou <me@fangyi.io>
---
    help: reword explanation line for developer interfaces
    
    Signed-off-by: Fangyi Zhou me@fangyi.io

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1330%2Ffangyi-zhou%2Fhelp-doc-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1330/fangyi-zhou/help-doc-fix-v1
Pull-Request: https://github.com/git/git/pull/1330

 help.c          | 2 +-
 t/t0012-help.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/help.c b/help.c
index ec670d5f68b..d04542d8261 100644
--- a/help.c
+++ b/help.c
@@ -39,7 +39,7 @@ static struct category_description main_categories[] = {
 	{ CAT_synchingrepositories, N_("Low-level Commands / Syncing Repositories") },
 	{ CAT_purehelpers, N_("Low-level Commands / Internal Helpers") },
 	{ CAT_userinterfaces, N_("User-facing repository, command and file interfaces") },
-	{ CAT_developerinterfaces, N_("Developer-facing file file formats, protocols and interfaces") },
+	{ CAT_developerinterfaces, N_("Developer-facing file formats, protocols and other interfaces") },
 	{ 0, NULL }
 };
 
diff --git a/t/t0012-help.sh b/t/t0012-help.sh
index 4ed2f242eb2..dbfc5c82676 100755
--- a/t/t0012-help.sh
+++ b/t/t0012-help.sh
@@ -231,7 +231,7 @@ test_expect_success "'git help -a' section spacing" '
 
 	User-facing repository, command and file interfaces
 
-	Developer-facing file file formats, protocols and interfaces
+	Developer-facing file formats, protocols and other interfaces
 	EOF
 	test_cmp expect actual
 '

base-commit: d3fa443f97e3a8d75b51341e2d5bac380b7422df
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] help: reword explanation line for developer interfaces
  2022-09-16 13:05 [PATCH] help: reword explanation line for developer interfaces Fangyi Zhou via GitGitGadget
@ 2022-09-16 16:19 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2022-09-16 16:19 UTC (permalink / raw)
  To: Fangyi Zhou via GitGitGadget
  Cc: git, Fangyi Zhou, Ævar Arnfjörð Bjarmason

"Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Fangyi Zhou <me@fangyi.io>
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---
>     help: reword explanation line for developer interfaces
>     
>     Signed-off-by: Fangyi Zhou me@fangyi.io

> -	{ CAT_developerinterfaces, N_("Developer-facing file file formats, protocols and interfaces") },
> +	{ CAT_developerinterfaces, N_("Developer-facing file formats, protocols and other interfaces") },

Yuck.  Thanks for catching this.

>  	{ 0, NULL }
>  };
>  
> diff --git a/t/t0012-help.sh b/t/t0012-help.sh
> index 4ed2f242eb2..dbfc5c82676 100755
> --- a/t/t0012-help.sh
> +++ b/t/t0012-help.sh
> @@ -231,7 +231,7 @@ test_expect_success "'git help -a' section spacing" '
>  
>  	User-facing repository, command and file interfaces
>  
> -	Developer-facing file file formats, protocols and interfaces
> +	Developer-facing file formats, protocols and other interfaces
>  	EOF

Apparently the writer of the test was not doing a good job; and of
course the reviewers, too X-.

These all came from 844739ba (git docs: add a category for file
formats, protocols and interfaces, 2022-08-04), as a part of a
large series.

Will queue.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-16 16:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 13:05 [PATCH] help: reword explanation line for developer interfaces Fangyi Zhou via GitGitGadget
2022-09-16 16:19 ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).