From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 844DB1F403 for ; Sun, 16 Oct 2022 16:52:07 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="ie6yOFQw"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229694AbiJPQwE (ORCPT ); Sun, 16 Oct 2022 12:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiJPQwD (ORCPT ); Sun, 16 Oct 2022 12:52:03 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9434D30576 for ; Sun, 16 Oct 2022 09:52:01 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D9D1F155178; Sun, 16 Oct 2022 12:51:58 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=wB+7E1o/1yUy Zmc52fK+ppJTDa0skxAeMlJqAwMo2Gs=; b=ie6yOFQw6weMY+ISFzAyeTh40dBH k9tmzldMeUdIo1agKhcmnlA/mwnZyn738gaORymN8lm6G68C51jojYU/TuOGUYkA EqYrY87ee35rq5oVFpXH5mGXNwuSJSgMAFH26V3ryynAIh75Vt5TLF6Kcq7corO4 NgZZiEufLP8utUU= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C113C155177; Sun, 16 Oct 2022 12:51:58 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 1F6DD155176; Sun, 16 Oct 2022 12:51:58 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZw==?= Danh Cc: skrab-sah via GitGitGadget , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , skrab-sah Subject: Re: [PATCH v2] abspath.h file is generated by makeheaders tool References: Date: Sun, 16 Oct 2022 09:51:56 -0700 In-Reply-To: (=?utf-8?B?IsSQb8OgbiBUcuG6p24g?= =?utf-8?B?Q8O0bmc=?= Danh"'s message of "Sun, 16 Oct 2022 20:13:45 +0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: D90D5182-4D72-11ED-9B12-2AEEC5D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C4=90o=C3=A0n Tr=E1=BA=A7n C=C3=B4ng Danh writes= : > This will break cross-compilation. > At the very least, we needs to use either HOSTCC (likes linux project), > HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile > makeheaders > > So, something like (not tested, whatsoever): I find it a bit irresponsible to leave the suggestion sounding as if this is a good idea as long as it does not break cross-compilation, which will (mis)lead the original poster to waste even more time on this topic (and waste others' time on responding to it), so let me repeat what I already said a few times. Whether the headers mechanically generated gets committed or not, this line of change is unwelcome. Developers should be able to look at the header files (and interface document, if we ever generate one out of structured comments in the header files) when using common functions that they are not (yet) familiar with, and we want to see our header files manually curated. Thanks.