From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C0DC21F47C for ; Wed, 25 Jan 2023 17:17:57 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=FeeG1h1T; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236194AbjAYRRz (ORCPT ); Wed, 25 Jan 2023 12:17:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236191AbjAYRRx (ORCPT ); Wed, 25 Jan 2023 12:17:53 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E89F4CC03 for ; Wed, 25 Jan 2023 09:17:51 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso2747559pjj.1 for ; Wed, 25 Jan 2023 09:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=AAZAaTbNA2z+x2Pd7aPjFZWjNXKpuF3xgqY6Aca529M=; b=FeeG1h1T1hBocP2G70E/86BwO91vnl0B2f78koGINvQtISZ7HUoPEsye87PHHVhejM njKOwLTri7V/ePxKNebhoqSnCiVN8u19K2e4cFaiB8SDQoIU5aueINCuId5NdxQWl0uS QG8xy3Nc+0xuWzG2qghB9zvYT1UNXV6ndxySY0hhoICKb9xoWyDOXhdl9uOsxPGh0cyr nSVx0Spdm4LPAWfgM34HY1VlwyCAcUs6L9BQYCW+hUK//FJmEIlwbcP/kvytqQ2E6OHb vYthEnBb96xNxWQYrxFgDlMIum8VLAl/8ettk5J7YdLLb+1WJhdWrkDNbvsOLLxZfEbC KWLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AAZAaTbNA2z+x2Pd7aPjFZWjNXKpuF3xgqY6Aca529M=; b=3s/sOt7lOcN5lD39ka8pILXvszwgWV+mO3FNVUMdzOp5SJBQ0Yr9ZMuJZwnU3ChBmo NyLzYdodls3XkFiNYU/5vzXydh0R21A1ch41WkGdjVzbqgpDTU4g3e4A7vIpRaL0oDVv lAF3CLriImr1cwHkdUzQLSZ08C4YBzVCto4F/F701RL5EDOG2CdVAcf4+/RPpLOKGj41 9fBVwiMCGMfxQswWkOAUxab+HVnWkFaN3K6doOAksQe2Bvftg2I24ntlfD9dvVT6f3JZ givHctD2YCM9m3fgUt01qpcWyotid0mjknER85EV7cPz14cV03LQ+TOoSNSnO/FIzO4a nkOw== X-Gm-Message-State: AFqh2kq8545ra/NpXZ5g3NlFsfg/f2vSTtGgIoPuQwN4eveCZvkBoI+z e+Qkejbf971CcrLoY3k6es0= X-Google-Smtp-Source: AMrXdXu0jCcpZGHdGpHmcpF+vxpmGHww8zbtGiheVF035TrQlSu37X+CSXazdeq8+EL9WubkovVGdw== X-Received: by 2002:a17:90b:91:b0:225:ce95:dc15 with SMTP id bb17-20020a17090b009100b00225ce95dc15mr32880869pjb.29.1674667071344; Wed, 25 Jan 2023 09:17:51 -0800 (PST) Received: from localhost (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id y15-20020a17090a474f00b00226eadf094dsm1918390pjg.30.2023.01.25.09.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 09:17:50 -0800 (PST) Sender: Junio C Hamano From: Junio C Hamano To: Adam Szkoda Cc: Adam Szkoda via GitGitGadget , git@vger.kernel.org, Phillip Wood , Fabian Stelzer Subject: Re: [PATCH v2] ssh signing: better error message when key not in agent References: Date: Wed, 25 Jan 2023 09:17:50 -0800 In-Reply-To: (Adam Szkoda's message of "Wed, 25 Jan 2023 13:46:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Adam Szkoda writes: >> We do >> not pass filename yet with this pushl(), because ... >> >> > + if (literal_ssh_key) { >> > + strvec_push(&signer.args, "-U"); >> > + } >> >> ... when we give a literal key, we want to insert "-U" in front, and then >> >> > + strvec_push(&signer.args, buffer_file->filename.buf); >> >> ... the filename. Which makes sense. > > I'm not sure what you mean in this paragraph. If there's something > more that needs to be done, I'd appreciate it if you could rephrase > it. "Which makes sense." is the key conclusion. Instead of saying "This part of the patch looks good" without explaining why I say so (it could be that I am saying so without really reading or understanding the changes or thinking the ramifications of the change through), the earlier parts that lead to the conclusion is a way to give weight to the conclusion. In other words, it is meant to show that the reviewer did read the patch well enough to understand the reasoning behind it. Thanks.