From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2D8651F428 for ; Fri, 10 Mar 2023 18:09:04 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=RpDc93k9; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230407AbjCJSIz (ORCPT ); Fri, 10 Mar 2023 13:08:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbjCJSIx (ORCPT ); Fri, 10 Mar 2023 13:08:53 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7989F62324 for ; Fri, 10 Mar 2023 10:08:46 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id i10so6466942plr.9 for ; Fri, 10 Mar 2023 10:08:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678471726; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=3KqtW559Qfcgg0srtfbnzjkYAlM0KV3i7PB3qqJddmk=; b=RpDc93k9sFxlNl301vtw5Xcd59MOSVmhtVXqP/p3yIHAyYumx3xXl4q0/zfdrCoCV4 SRoYwQyt0J0aoXdPp3jqL7omCdl+qZY81euIUo1FiQFGOgWSsy7fP4BSF2KJuwWgd9Bm AFkJWFb+65qIyOgy6cYJo3QlpM/nIGaRrI9k7zwRFNDX7CSHkjzUGAKt7nIKEBh/8Rw+ ru7bPMQkEwARtOws127s4jKBsw+BL1rIjwm/3RcFfqFd/I5Ygr3vwkgZxFE7nOUbUdJf yfGSlDKLIryehJRi8CHOVv/no0R/F7/nrp8nMIbzYa8bXodeSzw2A2dum73tztoT7Zeh CwqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678471726; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3KqtW559Qfcgg0srtfbnzjkYAlM0KV3i7PB3qqJddmk=; b=kl4VlEbZ1tInaHHbMr3YikO/OH+F4WCL5xCjC5PW0niVChp5RAX0tVVs/BY0QRNI0d AntNhaNEKu6dDBQld6PFlxynJdOB38rcZ/LC9buOL+zfSRj0SoZnccKKsPUCz7d+61Sy Kt7dJkD2s+aTUN6G+flUGrhGC2mnXb3Xo6Cm5tBjNHKD5VZtTYX2QNF2UXkxyzUjPDee IMWdarCxCRbdtt36h5+/TWhE9KEfIwXRR4KzzA4f1Qf4HuK6VXgkcL8IA4LwIsidOagu XT3wOdWu1ibDFljqVpKP8oIiGpdO0Te2lVCSI9mfiLEsfUxs6hs5NqP1Ai9MRHHwNvx3 npOg== X-Gm-Message-State: AO0yUKV+WZomdBfrCP6Sw0x4AM7fagEMJkPi2iNgNpU2x6mngcrtU/EO fHMZQhb+0HtNXw+PWGThB3M= X-Google-Smtp-Source: AK7set8i/G+5TKG+z7iIqvmAbDFxkQQOgVH4CDwi+GlF2mvYpQGoAKcUTdmjIjsNddwBlNx+K6Uplw== X-Received: by 2002:a17:902:be13:b0:19f:1871:3dcd with SMTP id r19-20020a170902be1300b0019f18713dcdmr683970pls.5.1678471725863; Fri, 10 Mar 2023 10:08:45 -0800 (PST) Received: from localhost (83.92.168.34.bc.googleusercontent.com. [34.168.92.83]) by smtp.gmail.com with ESMTPSA id q6-20020a170902788600b0019c2cf1554csm341914pll.13.2023.03.10.10.08.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 10:08:45 -0800 (PST) Sender: Junio C Hamano From: Junio C Hamano To: "Derrick Stolee via GitGitGadget" Cc: git@vger.kernel.org, me@ttaylorr.com, vdye@github.com, Jeff King , Derrick Stolee Subject: Re: [PATCH v2 1/8] for-each-ref: add --stdin option References: Date: Fri, 10 Mar 2023 10:08:45 -0800 In-Reply-To: (Derrick Stolee via GitGitGadget's message of "Fri, 10 Mar 2023 17:20:56 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Derrick Stolee via GitGitGadget" writes: > When reading from stdin, we populate the filter.name_patterns array > dynamically as opposed to pointing to the 'argv' array directly. This > requires a careful cast while freeing the individual strings, > conditioned on the --stdin option. Indeed. Thanks for carefully describing the concerns you had. Looking good. I'll read on.