From: Junio C Hamano <gitster@pobox.com>
To: Sanchit Jindal <sanchit1053@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Sanchit Jindal via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] t9803: update commit messages and description
Date: Thu, 21 Mar 2024 16:25:33 -0700 [thread overview]
Message-ID: <xmqqsf0j5frm.fsf@gitster.g> (raw)
In-Reply-To: <CAN7Jk_3A5c=5E+CNyncaT9qe_d85_p6ZHNzJPd0E5ZSjG1kQng@mail.gmail.com> (Sanchit Jindal's message of "Fri, 22 Mar 2024 01:58:21 +0530")
Sanchit Jindal <sanchit1053@gmail.com> writes:
> I have created another patch with a more descriptive commit message,
> and after squashing it with the earlier commit. I hope it is satisfactory
Hopefully. What GGG sent with v2 label still was a 2-patch series,
whose [2/2] patch was an empty patch, though.
> I wanted to ask, Is it possible to send the patches created using
> `git format-patch` manually using gmail, Or the default headers
> applied by `send-email` required.
I do not know where you are using gmail from (I know that Android
version has no way to send text-only e-mail for example), but when
cutting and pasting the output from format-patch, you should make
sure
* Remove "From <commit object name> Mon Sep 17 00:00:00 2001"
marker line that signals the beginning of each patch message. It
is a mistake to leave this line in the body of your message.
* Remove "Date: " header. Do not leave this line in the body of
your message.
* Remove "Subject: " header and move its contents to your MUA's
Subject entry field.
* Remove "From: " header, and arrange that your MUA puts the same
"Sanchit Jindal <sanchit1053@gmail.com> on the From header. If
your MUA is not cooperating, you can leave that line in the body
of the message
* Your cut&paste does not corrupt whitespaces, like squashing two
consecutive spaces into one, removing the leading whitespaces,
turning a tab into a run of spaces, folding a line at a
whitespace in the middle of the message, etc.
* Your MUA does not turn your text message into HTML gunk.
As long as you do the above carefully, you should be OK. "git
format-patch --help" has a section on MUA specific hints, which also
might be helpful.
Thanks.
next prev parent reply other threads:[~2024-03-21 23:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 19:39 [PATCH 0/2] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Sanchit Jindal via GitGitGadget
2024-03-21 19:39 ` [PATCH 1/2] " sanchit1053 via GitGitGadget
2024-03-21 19:39 ` [PATCH 2/2] t9803: update commit messages and description Sanchit Jindal via GitGitGadget
2024-03-21 19:52 ` Eric Sunshine
2024-03-21 20:28 ` Sanchit Jindal
2024-03-21 23:25 ` Junio C Hamano [this message]
2024-03-21 20:29 ` [PATCH v2 0/2] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Sanchit Jindal via GitGitGadget
2024-03-21 20:29 ` [PATCH v2 1/2] " sanchit1053 via GitGitGadget
2024-03-21 20:29 ` [PATCH v2 2/2] t9803: update commit messages and description Sanchit Jindal via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsf0j5frm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sanchit1053@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).