From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Yuxuan Shui <yshuiv7@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.
Date: Wed, 12 Mar 2014 11:30:11 -0700 [thread overview]
Message-ID: <xmqqr467mfrg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8Dq5QyZdzCtew0qF37qThH8+05iTrD-ZOeBgbEukmCY5Q@mail.gmail.com> (Duy Nguyen's message of "Wed, 12 Mar 2014 17:47:19 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> By convention, no full stop in the subject line. The subject should
> summarize your changes and "add ..NONEG" is just one part of it. The
> other is "convert to use ...NONEG". So I suggest "parse-options:
> convert to use new macro OPT_SET_INT_NONEG()" or something like that.
>
> You should also explain in the message body (before Signed-off-by:)
> why this is a good thing to do. My guess is better readability and
> harder to make mistakes in the future when you have to declare new
> options with noneg.
As I said elsewhere, I am not sure if doubling the number of
OPT_<type> macros as your micro suggestion proposes is the right
solution to the problem.
What are we trying to solve?
next prev parent reply other threads:[~2014-03-12 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 10:50 [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG Yuxuan Shui
2014-03-12 10:47 ` Duy Nguyen
2014-03-12 17:25 ` Yuxuan Shui
2014-03-12 18:30 ` Junio C Hamano [this message]
2014-03-12 18:33 ` Yuxuan Shui
2014-03-12 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr467mfrg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).