git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Johannes Schindelin <johannes.schindelin@gmail.com>,
	Jens Lehmann <Jens.Lehmann@web.de>, Jeff King <peff@peff.net>
Subject: Re: [PATCHv5 3/3] submodule: Reimplement `module_clone` shell function in C
Date: Tue, 08 Sep 2015 15:46:23 -0700	[thread overview]
Message-ID: <xmqqr3m87cn4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kYAsNZ1huLrYOvyPtYHKoN4paBGXbY3OMX3SQNMwqCiKA@mail.gmail.com> (Stefan Beller's message of "Tue, 8 Sep 2015 11:31:17 -0700")

Stefan Beller <sbeller@google.com> writes:

> On Thu, Sep 3, 2015 at 3:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> +
>>> +     cp.no_stdin = 1;
>>> +     cp.no_stdout = 1;
>>> +     cp.no_stderr = 1;
>>
>> Output from "git clone" is not shown, regardless of --quiet option?
>
> Removed that.
>
>>> +     argc = parse_options(argc, argv, prefix, module_clone_options,
>>> +                          git_submodule_helper_usage, 0);
>>> +
>>> +     strbuf_addf(&sb, "%s/modules/%s", get_git_dir(), name);
>>
>> The original says
>>
>>         base_name=$(dirname "$name")
>> ...
> Slashes are already in use for submodule names as the name defaults
> to the path if no explicit name is given.

Ahh, OK, that base_name thing is so that "mkdir -p" can create a
surrounding directory without creating the final level, which is
left for 'git clone" to prepare.  I misread the code.  Thanks.

  reply	other threads:[~2015-09-08 22:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 21:42 [PATCHv5 0/3] submodule--helper: Have some refactoring only patches first Stefan Beller
2015-09-02 21:42 ` [PATCHv5 1/3] submodule: Reimplement `module_list` shell function in C Stefan Beller
2015-09-03 18:57   ` Junio C Hamano
2015-09-03 19:18     ` Stefan Beller
2015-09-02 21:42 ` [PATCHv5 2/3] submodule: Reimplement `module_name` " Stefan Beller
2015-09-02 21:42 ` [PATCHv5 3/3] submodule: Reimplement `module_clone` " Stefan Beller
2015-09-03 22:07   ` Junio C Hamano
2015-09-08 18:31     ` Stefan Beller
2015-09-08 22:46       ` Junio C Hamano [this message]
2015-09-03 23:17   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr3m87cn4.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).