From: Junio C Hamano <gitster@pobox.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Cc: Stefan Beller <sbeller@google.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Fengguang Wu <fengguang.wu@intel.com>,
ying.huang@intel.com, philip.li@intel.com, julie.du@intel.com
Subject: Re: [PATCH v6 0/4] Add --base option to git-format-patch to record base tree info
Date: Wed, 27 Apr 2016 08:04:45 -0700 [thread overview]
Message-ID: <xmqqr3dray9e.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160427073350.GA30342@yexl-desktop> (Ye Xiaolong's message of "Wed, 27 Apr 2016 15:33:50 +0800")
Ye Xiaolong <xiaolong.ye@intel.com> writes:
> On Tue, Apr 26, 2016 at 11:58:39AM -0700, Junio C Hamano wrote:
>
>>Let's hear from folks at Intel ;-) Both of the above sounds like
>>sensible enhancements to me.
>
> Shall I squash these enhancements in this series, or I need to make
> another patch for them?
The update being discussed is not a "oops, the series without this
update is embarrassingly flawed" fix, but rather "the series is good
enough to be used as-is, but here is to potentially make it even
better", I'd prefer to have it as a separate, follow-up patch that
applies on top of what has been queued. That way, if this turns out
to be not so good idea, removing it alone while preserving what is
already there will be easier, and also others who will be studying
the code to further enhance the heuristics of base selection in the
future will benefit.
next prev parent reply other threads:[~2016-04-27 15:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 7:51 [PATCH v6 0/4] Add --base option to git-format-patch to record base tree info Xiaolong Ye
2016-04-26 7:51 ` [PATCH v6 1/4] patch-ids: make commit_patch_id() a public helper function Xiaolong Ye
2016-04-26 7:51 ` [PATCH v6 2/4] format-patch: add '--base' option to record base tree info Xiaolong Ye
2016-04-26 7:51 ` [PATCH v6 3/4] format-patch: introduce --base=auto option Xiaolong Ye
2016-04-26 7:51 ` [PATCH v6 4/4] format-patch: introduce format.useAutoBase configuration Xiaolong Ye
2016-04-26 17:11 ` Stefan Beller
2016-04-26 17:21 ` [PATCH v6 0/4] Add --base option to git-format-patch to record base tree info Stefan Beller
2016-04-26 18:05 ` Junio C Hamano
2016-04-26 18:20 ` Stefan Beller
2016-04-26 18:30 ` Junio C Hamano
2016-04-26 18:43 ` Stefan Beller
2016-04-26 18:58 ` Junio C Hamano
2016-04-27 7:33 ` Ye Xiaolong
2016-04-27 15:04 ` Junio C Hamano [this message]
2016-04-27 15:45 ` Stefan Beller
2016-04-26 22:56 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr3dray9e.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=fengguang.wu@intel.com \
--cc=git@vger.kernel.org \
--cc=julie.du@intel.com \
--cc=philip.li@intel.com \
--cc=sbeller@google.com \
--cc=xiaolong.ye@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).