Re: [Bug?] log -p -W showing the whole file for a patch that adds to the end?

[Junio C Hamano <gitster@pobox.com>]

René Scharfe <l.s.r@web.de> writes:

> Am 24.05.2016 um 20:16 schrieb Junio C Hamano:
>> René Scharfe <l.s.r@web.de> writes:
>>
>>>    diff: factor out match_func_rec()
>>>    diff: handle appended chunks better with -W
>>>    diff: ignore empty lines before added functions with -W
>>>    diff: don't include common trailing empty lines with -W
>>>    grep: don't extend context to trailing empty lines with -W
>>>
>>>   grep.c        | 28 ++++++++++++++++++++++++--
>>>   xdiff/xemit.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>>>   2 files changed, 82 insertions(+), 9 deletions(-)
>
>> It is curious that this much behaviour change does not need any
>> changes in the test scripts.  We do not have sufficient coverage,
>> perhaps?
>
> Well, -W is not tested at all.  I'll include some in the next round.
> No need to hurry, it's too late to land in 2.9.0 anyway.

True.

I'd say that these patches are fine as they are, and follow-up patch
for adding -W tests (instead of rerolling them) is sufficient,
though.