git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH 3/3] i18n: git-stash: mark message for translation
Date: Tue, 09 Aug 2016 12:36:57 -0700	[thread overview]
Message-ID: <xmqqr39x91k6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1470654961-2842-3-git-send-email-vascomalmeida@sapo.pt> (Vasco Almeida's message of "Mon, 8 Aug 2016 11:16:01 +0000")

Vasco Almeida <vascomalmeida@sapo.pt> writes:

> Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
> ---
>  git-stash.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-stash.sh b/git-stash.sh
> index 22fb8bc..9cbd682 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -265,7 +265,7 @@ save_stash () {
>  	create_stash "$stash_msg" $untracked
>  	store_stash -m "$stash_msg" -q $w_commit ||
>  	die "$(gettext "Cannot save the current status")"
> -	say Saved working directory and index state "$stash_msg"
> +	say "$(eval_gettext "Saved working directory and index state \$stash_msg")"
>  
>  	if test -z "$patch_mode"
>  	then

There is another "say" without gettext in pop_stash function.  Don't
you want to do that one, too?

  reply	other threads:[~2016-08-09 19:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 11:15 [PATCH 1/3] i18n: setup: mark error messages for translation Vasco Almeida
2016-08-08 11:16 ` [PATCH 2/3] i18n: archive: mark errors " Vasco Almeida
2016-08-09 19:35   ` Junio C Hamano
2016-08-10 13:28     ` Vasco Almeida
2016-08-08 11:16 ` [PATCH 3/3] i18n: git-stash: mark message " Vasco Almeida
2016-08-09 19:36   ` Junio C Hamano [this message]
2016-08-10 10:50 ` [PATCH v2 1/3] i18n: setup: mark error messages " Vasco Almeida
2016-08-10 10:50   ` [PATCH v2 2/3] i18n: archive: mark errors " Vasco Almeida
2016-08-10 10:50   ` [PATCH v2 3/3] i18n: git-stash: mark messages " Vasco Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr39x91k6.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=vascomalmeida@sapo.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).