git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Brandon Williams <bmwill@google.com>,
	Git Mailing List <git@vger.kernel.org>,
	Stefan Beller <sbeller@google.com>,
	jonathantanmy@google.com
Subject: Re: [PATCH v3 0/2] bringing attributes to pathspecs
Date: Tue, 21 Mar 2017 08:51:47 -0700	[thread overview]
Message-ID: <xmqqr31qsk4s.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACsJy8BRTuH=xv_xvQPOkVaRcMXKnjgT77SXkwLkZ6aAvcTyHg@mail.gmail.com> (Duy Nguyen's message of "Tue, 21 Mar 2017 17:51:29 +0700")

Duy Nguyen <pclouds@gmail.com> writes:

> The series updated match_pathspec(), but that's only one of two
> pathspec filtering functions. The other is tree_entry_interesting()
> (e.g. for "git grep <tree>"). Do you have plans to support :(attr)
> there too? "No" is a perfectly fine answer (and it will end up in my
> forever growing backlog).
>
> The thing about tree_entry_interesting() is, we would want to stop
> traversing subtrees as soon as possible. Naively implemented, we would
> need to traverse all subtrees so we can call match_attrs(). That's not
> great. Oii I'm rambling.. I don't know yet how to implement this thing
> efficiently.

Thanks for great insights.  

It indeed will become issue when an overly broad pathspec pattern is
combined with an attribute requirement, e.g. ".:(attr=X)", and we
may have to devise a way to tell that there won't be any paths with
that satisfy the attribute requirement before descending into a tree
as an optimization.

  reply	other threads:[~2017-03-21 15:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 21:07 [PATCH 0/2] bringing attributes to pathspecs Brandon Williams
2017-03-09 21:07 ` [PATCH 1/2] pathspec: allow querying for attributes Brandon Williams
2017-03-09 22:19   ` Jonathan Tan
2017-03-10 18:26     ` Brandon Williams
2017-03-13  2:43   ` Junio C Hamano
2017-03-13 18:30     ` Stefan Beller
2017-03-09 21:07 ` [PATCH 2/2] pathspec: allow escaped query values Brandon Williams
2017-03-09 22:31   ` Jonathan Tan
2017-03-10 18:53     ` Brandon Williams
2017-03-09 21:22 ` [PATCH 0/2] bringing attributes to pathspecs Stefan Beller
2017-03-10 18:59 ` [PATCH v2 " Brandon Williams
2017-03-10 18:59   ` [PATCH v2 1/2] pathspec: allow querying for attributes Brandon Williams
2017-03-10 19:56     ` Jonathan Tan
2017-03-11  0:28       ` Brandon Williams
2017-03-10 18:59   ` [PATCH v2 2/2] pathspec: allow escaped query values Brandon Williams
2017-03-13 18:23   ` [PATCH v3 0/2] bringing attributes to pathspecs Brandon Williams
2017-03-13 18:23     ` [PATCH v3 1/2] pathspec: allow querying for attributes Brandon Williams
2017-03-13 18:23     ` [PATCH v3 2/2] pathspec: allow escaped query values Brandon Williams
2017-03-13 22:30     ` [PATCH v3 0/2] bringing attributes to pathspecs Junio C Hamano
2017-03-13 22:38       ` Brandon Williams
2017-03-21 10:51     ` Duy Nguyen
2017-03-21 15:51       ` Junio C Hamano [this message]
2017-03-21 16:52       ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr31qsk4s.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=pclouds@gmail.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).