mailing list mirror (one of many)
 help / Atom feed
From: Junio C Hamano <>
To: SZEDER Gábor <>
Subject: Re: [PATCH 1/2] describe: do not use cmd_*() as a subroutine
Date: Wed, 11 Oct 2017 15:00:37 +0900
Message-ID: <> (raw)
In-Reply-To: <>

SZEDER Gábor <> writes:

> Maybe you already considered all this WRT that cmd_name_rev() call, I
> don't know.  In any case, I think at least the subject line should
> spell out cmd_diff_index().

Perhaps.  The intent was to eradicate cmd_*() used as a subroutine,
so I'd rather opt to explain why name_rev() that does not return is
OK in this case in the log message without changing anything else.

Thanks for looking it over.

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 10:03 [PATCH] pkt-line: re-'static'-ify buffer in packet_write_fmt_1() Junio C Hamano
2017-10-10  4:06 ` [PATCH 0/2] Do not call cmd_*() as a subroutine Junio C Hamano
2017-10-10  4:06   ` [PATCH 1/2] describe: do not use " Junio C Hamano
2017-10-10 13:43     ` SZEDER Gábor
2017-10-11  6:00       ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox