git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Yuki Kokubun <orga.chem.job@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] filter-branch: fix errors caused by refs that point at non-committish
Date: Mon, 09 Apr 2018 08:10:53 +0900	[thread overview]
Message-ID: <xmqqr2np8fb6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: 5ab7d550.dc96620a.4b512.feab@mx.google.com

Yuki Kokubun <orga.chem.job@gmail.com> writes:

> References: <1521996898-7052-1-git-send-email-orga.chem.job@gmail.com>
> Content-Type: text/plain
>
> Sorry, I forgot add a line of "Reviewed-by".
> I'm gonna send the fixed patch again.

Do not worry too much about this.  Reviewed-by: added by patch
author is seen rather rarely, because the following sequence of
events need to happen:

 - The author sends a patch vN

 - A reviewer reviews vN and says "This is now Reviewed-by: me"

 - The author re-submits patch vN+1, where the only difference
   between vN and vN+1 is essentially _nothing_.  Except for the
   addition of "Reviewed-by:" by the reviewer.

But our typical patch injestion cycle is much faster and often the
last step does not happen ;-)

  reply	other threads:[~2018-04-08 23:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 10:35 [PATCH] filter-branch: consider refs/replace can refer to an object other than commit Yuki Kokubun
2018-03-21 15:31 ` [PATCH] filter-branch: consider refs can refer to an object other than commit or tag Yuki Kokubun
2018-03-21 17:21   ` Junio C Hamano
2018-03-21 20:00   ` Yuki Kokubun
2018-03-21 20:00     ` Junio C Hamano
2018-03-22 14:26     ` Yuki Kokubun
2018-03-22 17:01       ` Junio C Hamano
2018-03-23  2:15       ` Yuki Kokubun
2018-03-23  5:09         ` [PATCH v2] filter-branch: fix errors caused by refs that cannot be used with ^0 Yuki Kokubun
2018-03-23 20:20           ` Junio C Hamano
2018-03-24 19:41             ` [PATCH v3] filter-branch: fix errors caused by refs that point at non-committish Yuki Kokubun
2018-03-25 16:25               ` Junio C Hamano
2018-03-25 16:39                 ` Yuki Kokubun
2018-03-25 20:24                   ` Junio C Hamano
2018-03-25 16:54                 ` [PATCH v4] " Yuki Kokubun
2018-03-25 16:45                   ` Yuki Kokubun
2018-04-08 23:10                     ` Junio C Hamano [this message]
2018-03-25 17:01                   ` [PATCH v5] " Yuki Kokubun
2018-03-25 17:13                   ` [PATCH v4] " Junio C Hamano
2018-03-24 19:29           ` [PATCH] filter-branch: consider refs can refer to an object other than commit or tag Yuki Kokubun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr2np8fb6.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=orga.chem.job@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).