git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Ben Peart <Ben.Peart@microsoft.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
	Mike Hommey <mh@glandium.org>,
	Lars Schneider <larsxschneider@gmail.com>,
	Eric Wong <e@80x24.org>,
	Christian Couder <chriscool@tuxfamily.org>,
	Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1 0/8] Introducing odb remote
Date: Mon, 14 May 2018 17:12:58 +0900	[thread overview]
Message-ID: <xmqqr2mebqph.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180513103232.17514-1-chriscool@tuxfamily.org> (Christian Couder's message of "Sun, 13 May 2018 12:32:24 +0200")

Christian Couder <christian.couder@gmail.com> writes:

> This is a follow up from the patch series called "Promisor remotes and
> external ODB support" that I sent earlier this year.
>
> Following discussions of these patch series, where Junio said "a
> minimum s/ext/remote/ would clarify what it is", I decided to rename
> "external odb" to "odb remote".

In "external odb", "odb" is a noun, decorated by adjective
"external".  I would expect the same would apply to "remote" and
"odb".

> I am still open to another name, but I
> think that "odb remote" works well with "odb helper" that was already
> used in the series and is as good or perhaps better than "remote odb",
> as a "remote odb" I think would be easier to confuse with a regular
> "remote".

As long as our use of "remote" as a noun is understood as omitting
(an obvious) "repository" from a noun phrase "remote repository", I
do not think there is any confusion.


"odb remote" sounds like the phrase is about a noun "remote" (we do
use "remote" as a noun when talking about fetching and pushing, as a
short hand for "remote repository") that uses "odb" as an adjective
somehow (e.g. "this is one of those remotes defined but not for the
usual fetching and pushing, but for accessing its odb", or something
ilke that), which somehow does not sit well on my tongue nor in ears.
Perhaps that is because I am not well versed in languages whose natural
word order in a noun phrase is noun followed by adjective, but I dunno.

> Another obvious difference with the previous series is that this
> series is only about integrating with the promisor/narrow clone work
> and showing that it makes it possible to use more than one promisor
> remote.

Sounds like a sensible "incremental" approach.

Will read the patches and commet on them in another sitting.
Thanks.

      parent reply	other threads:[~2018-05-14  8:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 10:32 [PATCH v1 0/8] Introducing odb remote Christian Couder
2018-05-13 10:32 ` [PATCH v1 1/8] fetch-object: make functions return an error code Christian Couder
2018-05-15  1:28   ` Junio C Hamano
2018-05-13 10:32 ` [PATCH v1 2/8] Add initial odb remote support Christian Couder
2018-05-15  1:44   ` Junio C Hamano
2018-06-23 12:15     ` Christian Couder
2018-06-25 18:06       ` Junio C Hamano
2018-05-15  8:41   ` Ævar Arnfjörð Bjarmason
2018-05-13 10:32 ` [PATCH v1 3/8] odb-remote: implement odb_remote_get_direct() Christian Couder
2018-05-13 10:32 ` [PATCH v1 4/8] odb-remote: implement odb_remote_get_many_direct() Christian Couder
2018-05-13 10:32 ` [PATCH v1 5/8] odb-remote: add odb_remote_reinit() Christian Couder
2018-05-13 10:32 ` [PATCH v1 6/8] Use odb_remote_get_direct() and has_external_odb() Christian Couder
2018-05-13 10:32 ` [PATCH v1 7/8] Use odb.origin.partialclonefilter instead of core.partialclonefilter Christian Couder
2018-05-13 10:32 ` [PATCH v1 8/8] t0410: test fetching from many promisor remotes Christian Couder
2018-05-14  8:12 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr2mebqph.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Ben.Peart@microsoft.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=jeffhost@microsoft.com \
    --cc=jonathantanmy@google.com \
    --cc=larsxschneider@gmail.com \
    --cc=mh@glandium.org \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).