From: Junio C Hamano <gitster@pobox.com>
To: Leif Middelschulte <leif.middelschulte@gmail.com>
Cc: newren@gmail.com, git@vger.kernel.org, sbeller@google.com
Subject: Re: [PATCH] merge-submodule: reduce output verbosity
Date: Mon, 11 Jun 2018 11:04:17 -0700 [thread overview]
Message-ID: <xmqqr2ldb3oe.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180611173128.9917-1-leif.middelschulte@gmail.com> (Leif Middelschulte's message of "Mon, 11 Jun 2018 19:31:28 +0200")
Leif Middelschulte <leif.middelschulte@gmail.com> writes:
> From: Leif Middelschulte <Leif.Middelschulte@gmail.com>
>
> The output shall behave more similar to ordinary file merges' output to provide
> a more consistent user experience.
>
> Signed-off-by: Leif Middelschulte <Leif.Middelschulte@gmail.com>
> ---
> merge-recursive.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, both. Very much appreciated.
>
> diff --git a/merge-recursive.c b/merge-recursive.c
> index ac27abbd4..5eb907f46 100644
> --- a/merge-recursive.c
> +++ b/merge-recursive.c
> @@ -1208,7 +1208,7 @@ static int merge_submodule(struct merge_options *o,
> output(o, 3, _("Fast-forwarding submodule %s to the following commit:"), path);
> output_commit_title(o, commit_b);
> } else if (show(o, 2))
> - output(o, 2, _("Fast-forwarding submodule %s to %s"), path, oid_to_hex(b));
> + output(o, 2, _("Fast-forwarding submodule %s"), path);
> else
> ; /* no output */
>
> @@ -1220,7 +1220,7 @@ static int merge_submodule(struct merge_options *o,
> output(o, 3, _("Fast-forwarding submodule %s to the following commit:"), path);
> output_commit_title(o, commit_a);
> } else if (show(o, 2))
> - output(o, 2, _("Fast-forwarding submodule %s to %s"), path, oid_to_hex(a));
> + output(o, 2, _("Fast-forwarding submodule %s"), path);
> else
> ; /* no output */
next prev parent reply other threads:[~2018-06-11 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 20:00 [PATCHv2 0/3] Reroll of sb/submodule-merge-in-merge-recursive Stefan Beller
2018-05-15 20:00 ` [PATCH] git-submodule.sh: try harder to fetch a submodule Stefan Beller
2018-05-15 20:00 ` [PATCH] grep: handle corrupt index files early Stefan Beller
2018-05-15 20:00 ` [PATCH 1/3] submodule.c: move submodule merging to merge-recursive.c Stefan Beller
2018-05-15 20:00 ` [PATCH 2/3] merge-recursive: i18n submodule merge output and respect verbosity Stefan Beller
2018-05-16 1:17 ` Junio C Hamano
2018-05-15 20:00 ` [PATCH 3/3] Inform about fast-forwarding of submodules during merge Stefan Beller
2018-05-16 1:36 ` Elijah Newren
2018-05-16 1:36 ` Junio C Hamano
2018-05-16 1:42 ` Junio C Hamano
2018-06-04 18:48 ` [PATCH v4 0/1] merge-recursive: give notice when submodule commit gets fast-forwarded Leif Middelschulte
2018-06-04 18:48 ` [PATCH 1/1] " Leif Middelschulte
2018-06-07 5:22 ` Elijah Newren
2018-06-11 17:31 ` [PATCH] merge-submodule: reduce output verbosity Leif Middelschulte
2018-06-11 18:04 ` Junio C Hamano [this message]
2018-06-11 19:07 ` Leif Middelschulte
2018-05-15 20:02 ` [PATCHv2 0/3] Reroll of sb/submodule-merge-in-merge-recursive Stefan Beller
2018-05-15 20:15 ` Leif Middelschulte
2018-05-15 20:49 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2ldb3oe.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=leif.middelschulte@gmail.com \
--cc=newren@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).