From: Junio C Hamano <gitster@pobox.com>
To: "Michał Górny" <mgorny@gentoo.org>
Cc: Derrick Stolee <stolee@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Git Test Coverage Report (Friday, Nov 2)
Date: Sat, 03 Nov 2018 19:03:09 +0900 [thread overview]
Message-ID: <xmqqr2g2mqaq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1541231868.1028.2.camel@gentoo.org> ("Michał Górny"'s message of "Sat, 03 Nov 2018 08:57:48 +0100")
Michał Górny <mgorny@gentoo.org> writes:
> As for how involved... we'd just have to use a key that has split
> signing subkey. Would it be fine to add the subkey to the existing key?
> It would imply updating keyids/fingerprints everywhere.
Yes, that "everywhere" is exactly what I meant by "how involved",
and your suggestion answers "very much involved".
If we can easily add _another_ key with a subkey that is not the
primary one we use for other tests, without touching the existing
key and the existing tests that use it (including the one I touched
below--- we'd want to see a sig with a key that is not split is
shown with the same %GF and %GP), while adding a handful of new
tests that create signed objects under the new & split key and
view them with %GF and %GP, then the end result would be that we
managed to add a new test case where %GF/%GP are different without
making very much involved changes. I guess that was what I was
getting at.
Thanks.
>
>>
>> t/t7510-signed-commit.sh | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
>> index 19ccae2869..9ecafedcc4 100755
>> --- a/t/t7510-signed-commit.sh
>> +++ b/t/t7510-signed-commit.sh
>> @@ -176,8 +176,9 @@ test_expect_success GPG 'show good signature with custom format' '
>> 13B6F51ECDDE430D
>> C O Mitter <committer@example.com>
>> 73D758744BE721698EC54E8713B6F51ECDDE430D
>> + 73D758744BE721698EC54E8713B6F51ECDDE430D
>> EOF
>> - git log -1 --format="%G?%n%GK%n%GS%n%GF" sixth-signed >actual &&
>> + git log -1 --format="%G?%n%GK%n%GS%n%GF%n%GP" sixth-signed >actual &&
>> test_cmp expect actual
>> '
>>
next prev parent reply other threads:[~2018-11-03 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 2:16 Git Test Coverage Report (Friday, Nov 2) Derrick Stolee
2018-11-03 3:38 ` Junio C Hamano
2018-11-03 7:57 ` Michał Górny
2018-11-03 10:03 ` Junio C Hamano [this message]
2018-11-03 16:22 ` Michał Górny
2018-11-04 9:17 ` Junio C Hamano
2018-11-03 11:47 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr2g2mqaq.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mgorny@gentoo.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).