From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Dustin Spicuzza via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Dustin Spicuzza <dustin@virtualroadside.com>
Subject: Re: [PATCH 1/1] cvsexportcommit: force crlf translation
Date: Wed, 08 May 2019 19:59:51 +0900 [thread overview]
Message-ID: <xmqqr299fbyw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1905081248190.44@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 8 May 2019 12:56:26 +0200 (DST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> How about this:
>
> The offical CVS for Windows (called CVS NT) produces DOS line
> endings in its `cvs status` output. Let's teach our own
> `cvsexportcommit` command to handle that gracefully.
>
> It is unlikely that anybody wants to spend time "fixing" this in CVS NT,
> even less likely that anybody would take that patch, and even if that was
> the case, there will still be plenty of CVS NT versions out there that
> `cvsexportcommit` cannot handle.
>
> I think it would be best to just integrate this change in Git and be done
> with it. It's not like it adds a ton of maintenance burden there.
One thing that took some time (at least to me) to audit was that the
helper being touched is *NOT* limited to running "cvs status". If
other commands cared about passing binary data intact, this change
would have been disasterous. After seeing what external commands it
is told to drive, I think it is OK. It's not like we'd be updating
the program often and reusing the function blindly to accept possibly
binary data in a near future.
prev parent reply other threads:[~2019-05-08 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 21:58 [PATCH 0/1] Fix cvsexportcommit with CR/LF line endings Johannes Schindelin via GitGitGadget
2019-04-29 21:58 ` [PATCH 1/1] cvsexportcommit: force crlf translation Dustin Spicuzza via GitGitGadget
2019-05-07 9:22 ` Junio C Hamano
2019-05-07 13:51 ` Dustin Spicuzza
2019-05-07 14:02 ` Junio C Hamano
2019-05-08 10:56 ` Johannes Schindelin
2019-05-08 10:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr299fbyw.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dustin@virtualroadside.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).