From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`
Date: Thu, 03 Oct 2019 09:43:48 +0900 [thread overview]
Message-ID: <xmqqr23ud5ff.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1910022229340.46@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 2 Oct 2019 22:30:26 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> While at it, I invert the logic in v2: instead of forcing a prefix, I
> now force no prefix (and reduce the strip level from 1 to 0 when parsing
> the diff header).
Ah, that approach would also work and may be conceptually cleaner
than requiring a/ and b/ prefix and forcing them.
next prev parent reply other threads:[~2019-10-03 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 18:05 [PATCH 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
2019-10-02 18:05 ` [PATCH 1/1] range-diff: internally force `diff.noprefix=false` Johannes Schindelin via GitGitGadget
2019-10-02 18:34 ` Eric Sunshine
2019-10-02 19:56 ` Michal Suchánek
2019-10-02 20:06 ` Junio C Hamano
2019-10-02 20:30 ` Johannes Schindelin
2019-10-03 0:43 ` Junio C Hamano [this message]
2019-10-03 0:41 ` Junio C Hamano
2019-10-02 21:10 ` [PATCH v2 0/1] Avoid segmentation fault in git range-diff when diff.noprefix=true Johannes Schindelin via GitGitGadget
2019-10-02 21:10 ` [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true` Johannes Schindelin via GitGitGadget
2019-10-03 2:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr23ud5ff.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).