From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id BB5091F619
	for <e@80x24.org>; Tue, 10 Mar 2020 03:31:26 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726497AbgCJDbY (ORCPT <rfc822;e@80x24.org>);
        Mon, 9 Mar 2020 23:31:24 -0400
Received: from pb-smtp2.pobox.com ([64.147.108.71]:59977 "EHLO
        pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726197AbgCJDbX (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 9 Mar 2020 23:31:23 -0400
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id D124C55AF6;
        Mon,  9 Mar 2020 23:31:20 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=qJnvyIH2fBo8o6AqickY+Mlbn5I=; b=K2OVPq
        AAc0WAJFcw0JsrUcbQKpqIsDJFp7TlsHuYp2ThaH7VDmDxBAdbFSPalg9v5u92kd
        /1qEjUt7M1Bgfay5sXMrSHt2pUocY2eUw/rwn6Xtxvkc1v1vmc8ZRLY78u7NyiHO
        u82ZBdWYKkJGCRt9rEkqJGbiT3bzpZJk4uQnw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=FNik700O2Tq+rj8HS/zgMxxIXQFDjrwa
        1PBTSTYqYI3qvDHMsNRZXiJsUqqoztiaEAFkjyWxzO2J06WvLdSmEolGUIpCqHld
        JsQIYk7Nx64mcEqzi83PDpTvulvFeWMgtkso/eId+z9PMTSZ6q3I7MSvqz4wBOig
        JK9JF2W6gnI=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id C8F3355AF5;
        Mon,  9 Mar 2020 23:31:20 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.74.119.39])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 53BAD55AF4;
        Mon,  9 Mar 2020 23:31:20 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>
Cc:     git@vger.kernel.org, Michael J Gruber <git@grubix.eu>,
        Matthieu Moy <git@matthieu-moy.fr>,
        John Keeping <john@keeping.me.uk>,
        Karthik Nayak <karthik.188@gmail.com>,
        Jeff King <peff@peff.net>,
        Alex Henrie <alexhenrie24@gmail.com>,
        Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH v2 0/3] Teach ref-filter API to correctly handle CRLF in messages
References: <pull.576.git.1583692184.gitgitgadget@gmail.com>
        <pull.576.v2.git.1583807093.gitgitgadget@gmail.com>
Date:   Mon, 09 Mar 2020 20:31:19 -0700
In-Reply-To: <pull.576.v2.git.1583807093.gitgitgadget@gmail.com> (Philippe
        Blain via GitGitGadget's message of "Tue, 10 Mar 2020 02:24:50 +0000")
Message-ID: <xmqqr1y0evi0.fsf@gitster.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 9BDE3230-627F-11EA-859E-D1361DBA3BAF-77302942!pb-smtp2.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> The function find_subpos in ref-filter.c looks for two consecutive '\n' to
> find the end of the subject line, a sequence which is absent in messages
> using CRLF.

This is crucial, and makes it obvious why a change is needed.
Thanks for clearly writing it out.