From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org, Josh Steadmon <steadmon@google.com>
Subject: Re: [PATCH] trace2: log progress time and throughput
Date: Tue, 12 May 2020 15:14:13 -0700 [thread overview]
Message-ID: <xmqqr1voajii.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200512214420.36329-1-emilyshaffer@google.com> (Emily Shaffer's message of "Tue, 12 May 2020 14:44:20 -0700")
Emily Shaffer <emilyshaffer@google.com> writes:
> Rather than teaching only one operation, like 'git fetch', how to write
> down throughput to traces, we can learn about a wide range of user
> operations that may seem slow by adding tooling to the progress library
> itself. Operations which display progress are likely to be slow-running
> and the kind of thing we want to monitor for performance anyways. By
> showing object counts and data transfer size, we should be able to
> make some derived measurements to ensure operations are scaling the way
> we expect.
Excellent observation ;-)
>
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> One note: by putting trace collection into the progress library, we end
> up with data events which have titles like "Receiving objects" - not
> very machine-parseable. An alternative might be to ask for a
> machine-readable title in the progress struct, but I didn't think it was
> worth the code churn.
Perhaps make it an optional member of the struct, and convert only a
selected few callers to set it and see how well it helps, while
leaving all the other callers set NULL to the member to keep showing
not-very-useful titles?
> CI run here, although it failed on the same error Junio noted today[1]:
I think Dscho's latest patch, even though it didn't mention my message,
is to fix that error. So with that queued in the same batch, we'll
see a full CI coverage again.
Will queue. Thanks.
next prev parent reply other threads:[~2020-05-12 22:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 21:44 [PATCH] trace2: log progress time and throughput Emily Shaffer
2020-05-12 22:14 ` Junio C Hamano [this message]
2020-05-13 19:46 ` Josh Steadmon
2020-05-15 10:59 ` Derrick Stolee
2020-05-15 15:27 ` Junio C Hamano
2020-05-15 16:09 ` Junio C Hamano
2020-05-15 16:49 ` Derrick Stolee
2020-05-15 17:00 ` Junio C Hamano
2020-05-15 19:37 ` Jeff Hostetler
2020-05-15 19:44 ` Jeff Hostetler
2021-06-21 1:24 ` Ævar Arnfjörð Bjarmason
2021-06-21 13:55 ` Elijah Newren
2021-06-21 14:51 ` Ævar Arnfjörð Bjarmason
2021-06-21 20:28 ` Elijah Newren
2021-06-23 2:55 ` Taylor Blau
2021-06-23 3:29 ` Chris Torek
2021-06-23 3:42 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1voajii.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).