From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Demi M. Obenour" <athena@invisiblethingslab.com>,
Git <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] rev-parse: handle --end-of-options
Date: Tue, 10 Nov 2020 14:23:34 -0800 [thread overview]
Message-ID: <xmqqr1p06ec9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201110214019.GC788740@coredump.intra.peff.net> (Jeff King's message of "Tue, 10 Nov 2020 16:40:19 -0500")
Jeff King <peff@peff.net> writes:
> This patch lets callers write:
>
> git rev-parse --end-of-options "$rev" -- "$path"
>
> and:
>
> git rev-parse --verify --end-of-options "$rev"
>
> which will both treat "$rev" always as a revision parameter.
Nice. The only iffy case I can think of is that we can never have
"--" to specify a rev, because with "git cmd -- -- path" we don't
know which double-dash among the two is the disambiguator that makes
the other double-dash to be either rev or path, but that is not a
new problem with this change.
> +test_expect_success 'verify respects --end-of-options' '
> + git update-ref refs/heads/-tricky HEAD &&
> + git rev-parse --verify HEAD >expect &&
> + git rev-parse --verify --end-of-options -tricky >actual &&
> + test_cmp expect actual
> +'
;-) Or refs/heads/--tricky?
The whole thing looked good. Thanks.
next prev parent reply other threads:[~2020-11-10 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:32 check_refname_format allows refs with components that begin with -, even though `git tag` does not Demi M. Obenour
2020-11-10 20:09 ` Junio C Hamano
2020-11-10 21:35 ` Jeff King
2020-11-10 21:37 ` [PATCH 1/3] rev-parse: don't accept options after dashdash Jeff King
2020-11-10 21:38 ` [PATCH 2/3] rev-parse: put all options under the "-" check Jeff King
2020-11-10 21:40 ` [PATCH 3/3] rev-parse: handle --end-of-options Jeff King
2020-11-10 22:23 ` Junio C Hamano [this message]
2020-11-10 22:28 ` Demi M. Obenour
2020-11-11 2:22 ` Jeff King
2020-11-10 21:33 ` check_refname_format allows refs with components that begin with -, even though `git tag` does not Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1p06ec9.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=athena@invisiblethingslab.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).