From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5E2AD1F9FC for ; Thu, 25 Mar 2021 20:10:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbhCYUJf (ORCPT ); Thu, 25 Mar 2021 16:09:35 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:52760 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhCYUJb (ORCPT ); Thu, 25 Mar 2021 16:09:31 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 0E2BEA4B7A; Thu, 25 Mar 2021 16:09:31 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=/iEZvDy5cGB+iaimm9vFk5Xa+QM=; b=gn6lS6 DJTEZdtwca0b30Ptwr/rD3wVraDiI/MM4I0Z8jA7BCLj3MFHDSQvvxFPHS8+lKno 8RnBusWRpNfY1lEt+IXBcvPI1th3/4/3G1NLyukdPPN83hUHFofj4RtBP7LPt5L+ 5SHHZSlOU5OJ1jdtCCGqduGwWe/tqcK08hyVk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=nIIFFrML2XDLJYFwZlGpkQeC1THux/KK eyF719McnbuIPrC5ennb+KnjXO4iYcNydfMDDtq9SgkXPkfYFfgSTNUdC8eoaD9E hJYXiRkHsdyTiXvv3VyxkSOQxU6KFL8bDUgulQ1JZvmZdNT0aSLYFd+JMnaTcN0V PNjwB0c/H4I= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 036BAA4B79; Thu, 25 Mar 2021 16:09:31 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 7DEACA4B78; Thu, 25 Mar 2021 16:09:30 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Stavros Ntentos Cc: bagasdotme@gmail.com, git@vger.kernel.org, pclouds@gmail.com, peff@peff.net, stdedos+git@gmail.com Subject: Re: [PATCH v1 1/1] pathspec: warn for a no-glob entry that contains `**` References: <20210325160921.12187-1-133706+stdedos@users.noreply.github.com> Date: Thu, 25 Mar 2021 13:09:29 -0700 In-Reply-To: <20210325160921.12187-1-133706+stdedos@users.noreply.github.com> (Stavros Ntentos's message of "Thu, 25 Mar 2021 18:09:21 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 022A542C-8DA6-11EB-A66E-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Stavros Ntentos writes: > Ofc, if someone really wanted to solve this, someone > could rework the `void vreportf` split and auto-pad > prefix at newline, but sounds like a project on its own ... But when it happens, this extra "\t" would get in the way and needs to be adjusted ;-) It has been on the radar for quite some time to apply the same principle for die(), error(), and warning() as how advise() shows its "hint:" prefix. The format strings given to these functions are end-user-facing and subject to localization, so there is no huge compatibility issues we need to be worried about. The test suite have fixed expectations and such a change must be accompanied by adjustment to the affected tests, though.