Re: Upstreaming Reviewed-by to git.git

[Junio C Hamano <gitster@pobox.com>]

Christian Couder <christian.couder@gmail.com> writes:

> On Mon, Mar 29, 2021 at 1:03 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
>> I had reviewing patches here, but how can my reviews be credited with
>> Reviewed-by tags to the applicable patches on git.git (Git SCM)
>> repo (upstream)?
>
> When you have reviewed a patch or a patch series, you can tell the
> reviewer you are ok with the patch or patch series, and that you are
> ok with them adding your "Reviewed-by: yourname <youremail>" to it.

I think you meant "you can tell the reviewEE", not reviewer.

In general, anybody can review a patch, but a review by somebody who
is not all that familiar with the codebase does not carry a lot of
weight.  Reviews from those who have already invested a lot in the
code that is being fixed or extended would obviously be very
helpful, as they are expected to know how the current code is
supposed to work well, and reviews from those who have worked on
other parts of the system that depend on the code that is being
fixed or extended would also be usefl, as they know what the callers
of the code being changed expect out of it.

So my suggestion to Bagas is not to worry too much about
"Reviewed-by" with your name, until you have your own code in the
codebase (and while doing so, you should worry about adding
reviewed-by by others).

In any case, reading others' patch, together with the original
version before the patch changed, is a great opportunity to learn
the codebase and how the project work in general.  It is highly
recommended.

Thanks.