From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "Han-Wen Nienhuys" <hanwen@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>
Subject: Re: What's cooking (draft for #4's issue this month)
Date: Wed, 14 Apr 2021 23:37:11 -0700 [thread overview]
Message-ID: <xmqqr1jcrr3c.fsf@gitster.g> (raw)
In-Reply-To: <YHeKFILFySGRo2Dc@camp.crustytoothpaste.net> (brian m. carlson's message of "Thu, 15 Apr 2021 00:34:28 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2021-04-14 at 23:22:19, Junio C Hamano wrote:
>> Here is the (local) test status near the tip of 'seen', relative to
>> the integration result last night.
>>
>> * hn/reftable has a preparatory change to use oidread() instead of
>> hashcpy() in places queued at its tip. This is essentially a
>> no-op in the codebase without bc/hash-transition-interop-part-1
>> and would be a bugfix with that topic. Please squash it into an
>> appropriate step in the series when updating the topic in the
>> future.
>>
>> * ab/unexpected-object-type topic has an assertion to catch
>> semantic conflicts with topics in-flight queued at its tip. It
>> would probably be safe to carry it until the topioc is merged to
>> 'master' and then remove it after the dust settles. Please
>> squash it into an appropriate step in the series when updating
>> the topic in the future.
>>
>> * The tip of 'seen' passes all the tests locally, except that t5540
>> fails when compiled with CC=clang (http-push exits with signal
>> 11). bc/hash-transition-interop-part-1, which is at the tip of
>> 'seen', seems to have this issue standalone. FYI, here is what
>> "clang --version" gives me:
>>
>> Debian clang version 11.0.1-2
>> Target: x86_64-pc-linux-gnu
>> Thread model: posix
>> InstalledDir: /usr/bin
>
> You should expect a reroll, so feel free to drop this if it breaks
> things for now and I'll figure out where things are going wrong.
I actually do appreciate the topic to be in 'seen', as these
integration exercises tend to serve as an early warning for
impending messy conflicts I'll need to be worried about.
I do worry about the memory requirement bloat of the object_id
structure, as we do need to keep one instance per object in-core,
but the squashable fix for the reftable topic given by Patrick
to replace use of hashcpy() with oidread() is still a good idea even
if we are going to use a different mechanism to keep track of which
object_id instance uses what hash algorithm, so again I am happy to
have seen your bc/hash-transition-interop-part-1 topic and had an
early chance to make it collide with others ;-)
Thanks.
next prev parent reply other threads:[~2021-04-15 6:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 1:11 What's cooking (draft for #4's issue this month) Junio C Hamano
2021-04-14 9:43 ` Patrick Steinhardt
2021-04-14 21:20 ` Junio C Hamano
2021-04-14 21:53 ` Junio C Hamano
2021-04-15 9:37 ` Jeff King
2021-04-15 18:02 ` Junio C Hamano
2021-04-14 21:31 ` Junio C Hamano
2021-04-14 23:22 ` Junio C Hamano
2021-04-14 23:26 ` Junio C Hamano
2021-04-15 0:34 ` brian m. carlson
2021-04-15 6:37 ` Junio C Hamano [this message]
2021-04-19 2:10 ` brian m. carlson
2021-04-19 23:14 ` Junio C Hamano
2021-04-15 12:58 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1jcrr3c.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).