git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: 'martin' <test2@mfriebe.de>,
	"'Felipe Contreras'" <felipe.contreras@gmail.com>,
	"'Andreas Schwab'" <schwab@linux-m68k.org>,
	git@vger.kernel.org,
	"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Subject: Re: [PATCH 5/5] config: add default aliases
Date: Fri, 02 Jul 2021 08:39:11 -0700	[thread overview]
Message-ID: <xmqqr1ggpvxc.fsf@gitster.g> (raw)
In-Reply-To: <03a401d76f45$e1c6fce0$a554f6a0$@nexbridge.com> (Randall S. Becker's message of "Fri, 2 Jul 2021 09:26:30 -0400")

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

> I am sorry if I am coming across too strongly on this subject, but
> I do think we are overloading alias capability and intruding on a
> domain that should be reserved for our users, not ourselves.

Well said.  The customization feature is for helping users, and we
shouldn't get in their way by adding unnecessary ones ourselves.

I wouldn't recommend us to force to our users even "co is for
checkout" that everybody seems to have.  Adopting such a
customization or not should be up to the users, and we should not
get in the way of other users who may want to say "co for me is
commit".

One thing that might (or might not) help to help users and projects
share the same set of aliases is to make it easier to audit shared
configuration file before inclusion.  I wonder if would help to
introduce "include.allow" and "include.block" configuration variables

    [include] ;; or [includeIf "<condition>"]
	path = /usr/share/git/contrib/svnlike.alias
	allow = alias.*

that tells us to only pay attention to the configuration keys that
match these 'allow' patterns when reading from the given path.

But in practice, 'alias' is one of the riskier things you can set in
the configuration file, so it is of dubious value to say "with this
allow-list feature, you do not have to worry about random cruft
defined in the included path---you only need to concentrate on
auditing alias.* configuration items in there and nothing else".


  parent reply	other threads:[~2021-07-02 15:39 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 10:05 [PATCH 0/5] Default aliases Felipe Contreras
2021-07-02 10:05 ` [PATCH 1/5] test: add missing whitespaces Felipe Contreras
2021-07-02 10:05 ` [PATCH 2/5] config: trivial style fix Felipe Contreras
2021-07-02 10:05 ` [PATCH 3/5] config: trivial struct initialization cleanup Felipe Contreras
2021-07-02 10:05 ` [PATCH 4/5] config: initialize origin_type correctly Felipe Contreras
2021-07-02 10:05 ` [PATCH 5/5] config: add default aliases Felipe Contreras
2021-07-02 10:10   ` Andreas Schwab
2021-07-02 10:17     ` Felipe Contreras
2021-07-02 10:31       ` Andreas Schwab
2021-07-02 10:46         ` Felipe Contreras
2021-07-02 10:54           ` Andreas Schwab
2021-07-02 10:44       ` martin
2021-07-02 10:54         ` Felipe Contreras
2021-07-02 11:15           ` martin
2021-07-02 13:26             ` Randall S. Becker
2021-07-02 13:41               ` Ævar Arnfjörð Bjarmason
2021-07-02 14:15                 ` Randall S. Becker
2021-07-02 14:43                   ` martin
2021-07-02 20:44                     ` Felipe Contreras
2021-07-02 22:03                     ` Randall S. Becker
2021-07-02 22:32                       ` Felipe Contreras
2021-07-02 15:39               ` Junio C Hamano [this message]
2021-07-02 20:41                 ` Felipe Contreras
2021-07-02 21:02               ` Felipe Contreras
2021-07-02 21:40                 ` martin
2021-07-02 22:16                   ` Felipe Contreras
2021-07-02 22:00                 ` Randall S. Becker
2021-07-02 22:31                   ` Felipe Contreras
2021-07-02 21:12             ` Felipe Contreras
2021-07-02 21:31               ` martin
2021-07-02 22:14                 ` Felipe Contreras
2021-07-02 11:32   ` Ævar Arnfjörð Bjarmason
2021-07-02 21:58     ` Felipe Contreras
2021-07-02 22:38       ` martin
2021-07-02 23:48         ` Felipe Contreras
2021-07-05 14:02         ` Randall S. Becker
2021-07-06 15:27           ` Randall S. Becker
2021-07-06 21:59           ` Felipe Contreras
2021-07-10 15:30           ` Philip Oakley
2021-07-03 10:50   ` Jeff King
2021-07-06 21:54     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr1ggpvxc.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=rsbecker@nexbridge.com \
    --cc=schwab@linux-m68k.org \
    --cc=test2@mfriebe.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).