From: Junio C Hamano <gitster@pobox.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Derrick Stolee <stolee@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] multi-pack-index: fix *.rev cleanups with --object-dir
Date: Tue, 24 Aug 2021 12:01:51 -0700 [thread overview]
Message-ID: <xmqqr1eioee8.fsf@gitster.g> (raw)
In-Reply-To: <f398645c2c946ea0d7cc6d8f603962dde5f7c4e0.camel@sipsolutions.net> (Johannes Berg's message of "Tue, 24 Aug 2021 09:59:02 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Mon, 2021-08-23 at 15:44 -0700, Junio C Hamano wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > If using --object-dir to point into a repo while the current
>> > working dir is outside, such as
>> >
>> > git init /repo
>> > git -C /repo ... # add some objects
>> > cd /non-repo
>> > git multi-pack-index --object-dir /repo/.git/objects/ write
>> >
>> > the binary will segfault trying to access the object-dir via
>> > the repo it found, but that's not fully initialized. Fix it
>>
>> OK, so write_midx_internal() was given an object_dir to work in,
>> made various changes to that directory, but at the very end of the
>> sequence, instead of clearing the revindex in the object_dir we have
>> been working in, cleared the odb associated with the repository.
>
> I'm not sure I'd claim "cleared the odb" but it's also not entirely
> clear to me what you mean by that.
"cleared the revindex in the wrong odb" is what I meant to say.
next prev parent reply other threads:[~2021-08-24 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 17:10 [PATCH v3] multi-pack-index: fix *.rev cleanups with --object-dir Johannes Berg
2021-08-23 22:44 ` Junio C Hamano
2021-08-24 7:59 ` Johannes Berg
2021-08-24 19:01 ` Junio C Hamano [this message]
2021-08-24 0:22 ` Taylor Blau
2021-08-24 7:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1eioee8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes@sipsolutions.net \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).