From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 411191F8C6 for ; Mon, 13 Sep 2021 03:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238440AbhIMD3b (ORCPT ); Sun, 12 Sep 2021 23:29:31 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:61704 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238149AbhIMD3b (ORCPT ); Sun, 12 Sep 2021 23:29:31 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id D392F15A4F2; Sun, 12 Sep 2021 23:28:15 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=qiSz4og6LzSqRF87g25/M6iUL 4xKg+kgUiigCI9/qz4=; b=BoWoBhiOL6M5z+Rwp+Wl1EfMKR/KTxRCMVVkUOuTK VvMAzGx79RMFnAY97sUiXqsNMOos746P0ILa47DKCj/IqlDtxNfkNxP+TXO6spxz qHWcFpKk8vwbH37O73YjBvFLQ7bn2VDxiddGEnKrwQB+YFAdhaFZxsk/qarp0GaG wo= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id CC58515A4F1; Sun, 12 Sep 2021 23:28:15 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.196.172.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 24AB715A4F0; Sun, 12 Sep 2021 23:28:13 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Jeff King , Johannes Schindelin , Eric Wong , Prathamesh Chavan , Peter Baumann , Philippe Blain , Andrei Rybak Subject: Re: [PATCH v3 1/4] git-submodule: remove unused is_zero_oid() function References: Date: Sun, 12 Sep 2021 20:28:11 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: A0507E60-1442-11EC-B1AD-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > The is_zero_oid() function in git-submodule.sh has not been used since > e83e3333b57 (submodule: port submodule subcommand 'summary' from shell > to C, 2020-08-13), so we can remove it. > > This was the last user of the sane_egrep() function in > git-sh-setup.sh. I'm not removing it in case some out-of-tree user > relied on it. Per the discussion that can be found upthread of [1]. I am OK with losing sane_egrep because it is not about a usefulness we can give to our users based on our deep knowledge on how Git works; it was rather based on our experience having to deal with silly choice GNU grep made about coloring that made it unpleasant to use in scripts. The users shouldn't have to depend on us for such a thing. But I am OK either way---the whole topic is more or less "Meh" to me. It is hard to draw a line between a collection of pointless churn and a generally useful clean-up, and I am having a hard time deciding which side of the boundary this falls.