From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 196CD1F953 for ; Mon, 13 Dec 2021 22:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240036AbhLMWSu (ORCPT ); Mon, 13 Dec 2021 17:18:50 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:57315 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235993AbhLMWSt (ORCPT ); Mon, 13 Dec 2021 17:18:49 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 498A51117A0; Mon, 13 Dec 2021 17:18:49 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=vdBTgzOMBGY+K8CYK28qcAdvBNlOLZ+fbw/bGW 179GU=; b=ZDjQMsHeoht7xe7T0p3yUlkrL3pjFRY6iNZFmG4TgBtWV1DbBimcul obMy/vMsFOESFJypUyNLrilFxZIlQlCVM+8/SvdzuaT+TLhwoBVVXeWZPERTueHU Qwgz44z8yQMbTMOwLo+3mOsWl5+QxBKepIw7r3tPHwm4qpOqxZ6CI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4078911179F; Mon, 13 Dec 2021 17:18:49 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 9902211179E; Mon, 13 Dec 2021 17:18:48 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Josh Steadmon Cc: git@vger.kernel.org, Jiang Xin , bagasdotme@gmail.com Subject: Re: [PATCH] l10n: README: call more attention to plural strings References: <25107068cbbf8c9ce6886e66e25dff19e072583f.1639425295.git.steadmon@google.com> Date: Mon, 13 Dec 2021 14:18:47 -0800 In-Reply-To: (Josh Steadmon's message of "Mon, 13 Dec 2021 14:02:15 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A5003032-5C62-11EC-A1F2-E10CCAD8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Josh Steadmon writes: > On 2021.12.13 13:56, Junio C Hamano wrote: >> Josh Steadmon writes: >> >> > In po/README.md, we point core developers to gettext's "Preparing >> > Strings" documentation for advice on marking strings for translation. >> > However, this doc doesn't really discuss the issues around plural form >> > translation, which can make it seem that nothing special needs to be >> > done in this case. >> > >> > Add a specific callout here about marking plural-form strings so that >> > the advice later on in the README is not overlooked. >> > >> > Signed-off-by: Josh Steadmon >> > --- >> > po/README.md | 5 ++++- >> > 1 file changed, 4 insertions(+), 1 deletion(-) >> > >> > diff --git a/po/README.md b/po/README.md >> > index dcd8436c25..fd1e024dd3 100644 >> > --- a/po/README.md >> > +++ b/po/README.md >> > @@ -219,7 +219,10 @@ General advice: >> > they're part of Git's API. >> > >> > - Adjust the strings so that they're easy to translate. Most of the >> > - advice in `info '(gettext)Preparing Strings'` applies here. >> > + advice in `info '(gettext)Preparing Strings'` applies here. Strings >> > + referencing numbers of items may need to be split into singular and >> > + plural forms; see the Q\_() wrapper in the C sub-section below for an >> > + example. >> > >> > - If something is unclear or ambiguous you can use a "TRANSLATORS" >> > comment to tell the translators what to make of it. These will be >> >> Sounds good to me, but I'd want an ack by those from the l10n >> department. >> >> Thanks. > > Hmm, I meant to CC both Jiang and Bagas, not sure why it didn't go > through. That's OK. We watch each other's back ;-)