From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,URIBL_CSS, URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CD3B31F953 for ; Wed, 5 Jan 2022 19:47:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243655AbiAETrT (ORCPT ); Wed, 5 Jan 2022 14:47:19 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:57919 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243651AbiAETrT (ORCPT ); Wed, 5 Jan 2022 14:47:19 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 5BCB1FF799; Wed, 5 Jan 2022 14:47:18 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=hnTgPQjmohJIY44fraBbeM/Q6Kbrn8p+J58iiO n4fJI=; b=vVJlm4sf8oT99/QoiceA4AeJINVDrU75epU/A4X94+u4viRrmib2OQ IhM0BSE1BPBedTdqNK+iZPYz4ZHiFaEU6E4U0g13wCJeSPkl58a8h/I0FwVtHpXW /kA4hsbLLBAPKug46Yai8J2EHA+0G0+0sr3tf1wOnUfD4a77Co1GI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 50FE5FF798; Wed, 5 Jan 2022 14:47:18 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 756A5FF797; Wed, 5 Jan 2022 14:47:17 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Phillip Wood Cc: John Cai via GitGitGadget , git@vger.kernel.org, Johannes Schindelin , John Cai Subject: Re: [PATCH v4 1/2] name-rev: deprecate --stdin in favor of --annotate-stdin References: <4e9200922a4c2c91e69e3b497fbf4c8702046a27.1641307776.git.gitgitgadget@gmail.com> <16666d32-833a-f3d7-351a-eeef7f25b002@gmail.com> Date: Wed, 05 Jan 2022 11:47:16 -0800 In-Reply-To: <16666d32-833a-f3d7-351a-eeef7f25b002@gmail.com> (Phillip Wood's message of "Wed, 5 Jan 2022 11:15:57 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 49C22FBC-6E60-11EC-8D01-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Phillip Wood writes: >> @@ -613,8 +622,8 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix) >> for_each_ref(name_ref, &data); >> name_tips(); >> - if (transform_stdin) { >> - char buffer[2048]; >> + if (annotate_stdin) { >> + struct strbuf sb = STRBUF_INIT; > > I think this hunk belongs in the next patch. Before posting a patch > series I find it helpful to run > > git rebase --keep-base -x'make -j4 git && cd t && prove -j4 I think might fail> :: --root=/dev/shm' > > to check that the individual patches compile and pass the relevant > tests. I've never got round to trying it but git-test[1] also lets you > test all the commits in a series Ahh, I saw and pointed out exactly the same mistake in an earlier round, but failed to spot it this time around. Thanks for spotting.