From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Michael J Gruber" <git@grubix.eu>
Subject: Re: [PATCH] http.c: clear the 'finished' member once we are done with it
Date: Wed, 25 May 2022 09:40:43 -0700 [thread overview]
Message-ID: <xmqqr14h8t10.fsf@gitster.g> (raw)
In-Reply-To: nycvar.QRO.7.76.6.2205251111300.352@tvgsbejvaqbjf.bet
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> This same analysis, of course, also puts a nail into the coffin of the
> `reserved_for_use` idea because while it would fix the reuse bug, it would
> unnecessarily squat on slots that might well be needed.
It is like that an in-kernel structure that represents a process has
to stay around in the zombie state until its exit status is culled.
With s/reserved_for_use/zombie/ the name of the new member would
make more sense ;-)
With the "slot->finished" trick, compared to the approach to delay
the reuse, we can reuse them a bit earlier, but because I do not
think we accumulate unbounded number of these zombie requests, and
when we run out the active slots in the active queue, and because
get_active_slot() will allocate a new one, the wastage might not be
too bad.
So, I am not sure if it is that bad to be called a nail in the
coffin.
In any case, https://github.com/git/git/actions/runs/2381379417 is
the run with the single liner "clear slot->finished before leaving"
with your other 3 gcc12 fixes. The tests are not clean because we
have linux-leaks complaining on ds/bundle-uri-more RFC patches and
win test (9) seems to have issues with t7527 (fsmonitor), but I am
taking the fact that any of the "win test" jobs even start as an
evidence that we have pleased gcc12 enough to get there?
Thanks.
next prev parent reply other threads:[~2022-05-25 16:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 18:04 [PATCH 0/2] quell a few gcc warnings Michael J Gruber
2022-05-06 18:04 ` [PATCH 1/2] dir.c: avoid gcc warning Michael J Gruber
2022-05-06 20:21 ` Junio C Hamano
2022-05-09 15:58 ` Taylor Blau
2022-05-07 6:14 ` Carlo Marcelo Arenas Belón
2022-05-06 18:04 ` [PATCH 2/2] http.c: " Michael J Gruber
2022-05-06 20:22 ` Junio C Hamano
2022-05-06 21:17 ` [PATCH] http.c: clear the 'finished' member once we are done with it Junio C Hamano
2022-05-07 5:40 ` Carlo Marcelo Arenas Belón
2022-05-07 18:42 ` Junio C Hamano
2022-05-07 19:11 ` Carlo Arenas
2022-05-23 21:58 ` Johannes Schindelin
2022-05-23 22:58 ` Junio C Hamano
2022-05-23 23:36 ` Junio C Hamano
2022-05-23 23:41 ` Johannes Schindelin
2022-05-24 0:02 ` Junio C Hamano
2022-05-24 6:31 ` Daniel Stenberg
2022-05-24 10:57 ` Johannes Schindelin
2022-05-24 17:45 ` Junio C Hamano
2022-05-26 14:15 ` Daniel Stenberg
2022-05-24 11:03 ` Johannes Schindelin
2022-05-24 17:15 ` Junio C Hamano
2022-05-24 20:16 ` Carlo Marcelo Arenas Belón
2022-05-24 20:45 ` Ævar Arnfjörð Bjarmason
2022-05-24 22:34 ` Junio C Hamano
2022-05-25 9:08 ` Michael J Gruber
2022-05-25 13:27 ` Ævar Arnfjörð Bjarmason
2022-05-24 22:16 ` Junio C Hamano
2022-05-24 23:19 ` Junio C Hamano
2022-05-25 2:02 ` Carlo Arenas
2022-05-24 20:38 ` Ævar Arnfjörð Bjarmason
2022-05-24 22:28 ` Junio C Hamano
2022-05-25 10:07 ` Johannes Schindelin
2022-05-25 16:40 ` Junio C Hamano [this message]
2022-05-06 20:41 ` [PATCH 2/2] http.c: avoid gcc warning Carlo Marcelo Arenas Belón
2022-05-09 11:22 ` [PATCH] detect-compiler: make detection independent of locale Michael J Gruber
2022-05-09 15:52 ` Junio C Hamano
2022-05-09 15:59 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr14h8t10.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).