From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 0F3481F4D7 for ; Sat, 28 May 2022 17:24:28 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="YHs+hCK8"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239076AbiE1RYY (ORCPT ); Sat, 28 May 2022 13:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbiE1RYV (ORCPT ); Sat, 28 May 2022 13:24:21 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9C0311A29 for ; Sat, 28 May 2022 10:24:20 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id F2E6E18E4D7; Sat, 28 May 2022 13:24:19 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=kPYITT1WliDK UOyMPBIO3swAOW8l1FD7ubAn7eYCkc8=; b=YHs+hCK8HQ5hkybGnTAdLfwYWFr+ r1oYuNj4Ll0BQ8s46FqRp4kaLJiehGGITzu5FufjuwuPTI5wXUIdLWlhxpsvOC33 dHTTsdN4lx67zJe6aK36H2n4dt7QtdqvAIVc8kBAg2V8VUsYLt1PF8bY3tjDQkEU QfiUbUJjuKl7tPU= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id EBA4318E4D6; Sat, 28 May 2022 13:24:19 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 9265F18E4D4; Sat, 28 May 2022 13:24:16 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: John Cai via GitGitGadget , git@vger.kernel.org, Emily Shaffer , John Cai Subject: Re: [PATCH] hook: provide GIT_HOOK for all hooks References: <220528.86bkvh3b3q.gmgdl@evledraar.gmail.com> Date: Sat, 28 May 2022 10:24:15 -0700 In-Reply-To: <220528.86bkvh3b3q.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sat, 28 May 2022 17:53:35 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 0038DC2C-DEAB-11EC-9598-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > But the commit message & documentation here really should be updated to > reflect that this is currently superfluous to inspecting argv in the > hook process, and that we're providing this anyway for XYZ reason. Or this probably is better added as part of the series that actually adds the mechanism to trigger hooks defined in the configuration file. =20 Then "we do not need it now, but we will in the future because we will do XYZ" does not have to be said, which is a huge plus. Thanks.