From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Stewart Smith <trawets@amazon.com>,
git@vger.kernel.org, Todd Zullinger <tmz@pobox.com>
Subject: Re: [PATCH] git-send-email: Add --no-validate-email option
Date: Tue, 21 Jun 2022 09:00:49 -0700 [thread overview]
Message-ID: <xmqqr13ihuq6.fsf@gitster.g> (raw)
In-Reply-To: <YrEMq+slLOHqw/hz@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 21 Jun 2022 00:11:23 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2022-06-20 at 00:44:27, Stewart Smith wrote:
>> The perl Email::Valid module gets things right, but this may not always
>> be what you want, as can be seen in
>> https://bugzilla.redhat.com/show_bug.cgi?id=2046203
>
> You should explain this in the body of the message, since we generally
> want to know the rationale behind the change even if RedHat moves away
> from Bugzilla in the future.
>
> You could say something like this:
>
> The Perl Email::Valid module correctly checks whether an email address
> is syntactically valid. However, in some cases, people have email
> addresses which are not syntactically valid, such as those where the
> local-part is more than 64 octets, and would like to use those
> addresses despite that fact.
>
>> So, add a --validate-email (default, current behavior) and
>> the inverse --no-validate-email option to be able to skip the check
>> while still having the Email::Valid perl module installed.
>>
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2046203
>
> I don't believe we generally include Fixes headers for external bugs.
All good comments; I have nothing to add here.
>> + # Email::Valid isn't always correct, so support a way to bypass
>> + # See https://bugzilla.redhat.com/show_bug.cgi?id=2046203
>
> Email::Valid is in fact correct. However, the email which you want to
> use doesn't conform to the RFC and isn't valid. So this should probably
> say something like, "Allow people to use an email address which is not
> valid according to the RFCs if the server accepts it."
I had exactly the same reaction. Again, I have nothing to add here.
Thanks.
>
> I think this patch would be fine as it stands with those changes. Unlike
> Ævar, I don't think we should get rid of Email::Valid, just like I don't
> think we should get rid of the transfer encoding checks. I support
> warning people before sending invalid emails, especially since I believe
> the address in question would not be deliverable through some mail
> servers (such as mine).
next prev parent reply other threads:[~2022-06-21 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 0:44 [PATCH] git-send-email: Add --no-validate-email option Stewart Smith
2022-06-20 8:28 ` Ævar Arnfjörð Bjarmason
2022-06-21 0:11 ` brian m. carlson
2022-06-21 16:00 ` Junio C Hamano [this message]
2022-06-21 22:12 ` Ævar Arnfjörð Bjarmason
2022-06-22 0:48 ` brian m. carlson
2022-06-30 11:18 ` Ævar Arnfjörð Bjarmason
2022-06-30 21:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr13ihuq6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=tmz@pobox.com \
--cc=trawets@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).