From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Jonathan Tan <jonathantanmy@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: write effective filter to trace2
Date: Mon, 18 Jul 2022 08:53:58 -0700 [thread overview]
Message-ID: <xmqqr12is9gp.fsf@gitster.g> (raw)
In-Reply-To: <de8d38fc-23e3-b876-87e8-7b4193bff44c@jeffhostetler.com> (Jeff Hostetler's message of "Mon, 18 Jul 2022 10:08:42 -0400")
Jeff Hostetler <git@jeffhostetler.com> writes:
> Yeah, the use of "none" gave me pause, but I didn't have a better idea
> at the time. I guess we have:
> (a) requested, supported, used.
> (b) "none used because the server doesn't support it" and
> (c) "none used because the user didn't request it" cases,
> right?
At these sites where the new traces are added, we cannot detect the
remaining case (d) "requested by the user, asked for the server, but
the server dropped the ball", I think the above covers the possible
cases that are interesting to us entirely.
> Perhaps it would be better to do:
> if (server_supports_filtering && args->filter_options.choice)
> trace2_data_string("fetch", r, "filter/effective", spec);
> else
> trace2_data_string("fetch", r, "filter/unsupported", spec);
>
> Using two different keywords.
>
> So that the log only contains "filter/effective" when it was actually
> used. And there is no "filter/effective" event when (for whatever
> reason) it was not in effect.
>
> Then the "filter/unsupported" event helps you with debugging. Did they
> hit a server that doesn't support filtering or did they have a typo in
> their filter spec?
>
> Then don't emit a message at all for the "not requested" case. And you
> can use the Git version number to know how to interpret it. There are
> other places where we don't bother sending messages where the value is
> a zero or empty.
Sounds alright. We could standardize the other way, which might
make the interpretation of individual trace entries independent of
the context easier, though.
Thanks.
next prev parent reply other threads:[~2022-07-18 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 17:29 [PATCH] fetch-pack: write effective filter to trace2 Jonathan Tan
2022-07-15 17:38 ` Jeff Hostetler
2022-07-15 18:28 ` Junio C Hamano
2022-07-15 19:09 ` Jonathan Tan
2022-07-15 20:10 ` Junio C Hamano
2022-07-15 20:49 ` Jonathan Tan
2022-07-18 14:08 ` Jeff Hostetler
2022-07-18 15:53 ` Junio C Hamano [this message]
2022-07-18 16:18 ` Jonathan Tan
2022-07-18 17:56 ` Junio C Hamano
2022-07-18 17:00 ` [PATCH v2] " Jonathan Tan
2022-07-18 19:47 ` Junio C Hamano
2022-07-25 18:56 ` Junio C Hamano
2022-07-26 16:28 ` Jonathan Tan
2022-07-26 16:27 ` [PATCH v3] " Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr12is9gp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).