From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id AABE31F54E for ; Sat, 20 Aug 2022 21:29:13 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="n9bQUERf"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232946AbiHTV1s (ORCPT ); Sat, 20 Aug 2022 17:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiHTV1r (ORCPT ); Sat, 20 Aug 2022 17:27:47 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 425A12A406 for ; Sat, 20 Aug 2022 14:27:47 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 7B941145644; Sat, 20 Aug 2022 17:27:46 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=1GdBStom6KyS nPTTWOZjvBG0d6Ns1mdM0dCZT3mEJLs=; b=n9bQUERfxbGIObxtsY7LmWR3UMm4 DWgLjiAWZpoJMt1Vc6Ds2USQXlly2LSS6mmlxeam5p0D3fXr7E7LRhJ1F7PMQLgN V77Eco62ac+Snt6gsxIvRyRJLeOSiNM4TdsEZkj3ViMTmvi/nWiLVtPzx8BLLSho rygo302a0pO3acY= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 72F53145641; Sat, 20 Aug 2022 17:27:46 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id C9B46145635; Sat, 20 Aug 2022 17:27:45 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: SZEDER =?utf-8?Q?G=C3=A1bor?= Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH v2 04/20] t0040-parse-options: test parse_options() with various 'parse_opt_flags' References: <20220725123857.2773963-1-szeder.dev@gmail.com> <20220819160411.1791200-1-szeder.dev@gmail.com> <20220819160411.1791200-5-szeder.dev@gmail.com> <20220820103128.GD3373722@szeder.dev> Date: Sat, 20 Aug 2022 14:27:44 -0700 In-Reply-To: <20220820103128.GD3373722@szeder.dev> ("SZEDER =?utf-8?Q?G?= =?utf-8?Q?=C3=A1bor=22's?= message of "Sat, 20 Aug 2022 12:31:28 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: EEB3D568-20CE-11ED-9BE4-CB998F0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org SZEDER G=C3=A1bor writes: > On Fri, Aug 19, 2022 at 11:18:20AM -0700, Junio C Hamano wrote: >> SZEDER G=C3=A1bor writes: >>=20 >> > +static void print_args(int argc, const char **argv) >> > +{ >> > + for (int i =3D 0; i < argc; i++) >> > + printf("arg %02d: %s\n", i, argv[i]); >> > +} >>=20 >> It is not November 2022 yet (cf. Documentation/CodingGuidelines). > > Oh, I've misunderstood =C3=86var's remarks about this in the previous > round, and thought it's fair game. If we make it a "fair game", when we find a platform that has problems with the syntax, we will have to find them and fix up many places. At least the number of the ones we let in by mistake are small and known, it may be still be manageable. It is how to be conservative. > It doesn't matter for these tests, but 'test-tool parse-options' uses > the same format to print args: As long as 99 is enough for us, I do not very much care. I just noticed an attempt to align that does not do a thorough job at it, and found it strange, that's all.