From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: Victoria Dye via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, shaoxuan.yuan02@gmail.com,
Victoria Dye <vdye@github.com>
Subject: Re: [PATCH] unpack-trees: fix sparse directory recursion check
Date: Fri, 02 Sep 2022 09:57:44 -0700 [thread overview]
Message-ID: <xmqqr10t90jb.fsf@gitster.g> (raw)
In-Reply-To: <8dea9ffe-d03b-f838-6cc5-db0de5024d9f@github.com> (Derrick Stolee's message of "Fri, 2 Sep 2022 09:32:01 -0400")
Derrick Stolee <derrickstolee@github.com> writes:
> Could it also happen if we are going from a commit without that
> sparse directory and then to a commit with that sparse directory? I
> think that would be a more common case, but I was unable to
> manipulate the test repo in t1092 to trigger this bug in the existing
> test cases.
>
> This makes me think that this bug _is_ extremely rare, so we don't
> need to rush this into a 2.37.4 or anything. It would be good to
> bring it into 2.38.0-rc0, though.
When the "test" part of the patch is applied directly on top of the
vd/sparse-reset-checkout-fixes topic without its "fix" part, the
newly added test fails, and with the "fix" part applied, everything
goes peachy. I think applying it on top of the topic as a fix to it
would be the most sensible. Any motivated distro packager can grab
the topic and merge to their long-term maintenance track that way
more easily.
Thanks all.
next prev parent reply other threads:[~2022-09-02 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 21:02 [PATCH] unpack-trees: fix sparse directory recursion check Victoria Dye via GitGitGadget
2022-09-02 9:03 ` Johannes Schindelin
2022-09-02 13:32 ` Derrick Stolee
2022-09-02 16:57 ` Junio C Hamano [this message]
2022-09-02 19:03 ` Shaoxuan Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr10t90jb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=shaoxuan.yuan02@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).