From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git_connect(): fix corner cases in downgrading v2 to v0
Date: Fri, 17 Mar 2023 15:15:49 -0700 [thread overview]
Message-ID: <xmqqr0tnf2i2.fsf@gitster.g> (raw)
In-Reply-To: <ZBS6wwWXcEBwGBm/@coredump.intra.peff.net> (Jeff King's message of "Fri, 17 Mar 2023 15:08:51 -0400")
Jeff King <peff@peff.net> writes:
> There's code in git_connect() that checks whether we are doing a push
> with protocol_v2, and if so, drops us to protocol_v0 (since we only know
> how to do v0 for fetches).
I had to read this three times to make sense out of it, and then
after reading the NEEDSWORK comment at the beginning of
git_connect(), started to suspect that there is a bit of typo there
that made it confusing to me. Either "(since we only know how to do
v2 for fetches)", or "(since we only know how to push via v0)",
perhaps.
Other than that, superb reasoning and a very clear solution. Will
apply. Thanks.
next prev parent reply other threads:[~2023-03-17 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 19:08 [PATCH] git_connect(): fix corner cases in downgrading v2 to v0 Jeff King
2023-03-17 22:15 ` Junio C Hamano [this message]
2023-03-17 22:22 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0tnf2i2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).