From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] apply: avoid using fixed-size buffer in write_out_one_reject()
Date: Tue, 16 Apr 2024 15:39:14 -0700 [thread overview]
Message-ID: <xmqqr0f5c4q5.fsf@gitster.g> (raw)
In-Reply-To: <a93cd243-cb17-4ad5-8d23-30768dc5213b@web.de> ("René Scharfe"'s message of "Tue, 16 Apr 2024 22:16:05 +0200")
René Scharfe <l.s.r@web.de> writes:
> Take care to work around (arguably buggy) implementations of free(3)
> that change errno by calling it only after using the errno value.
;-).
The "do everything including giving an error message, jump to the
exit label where resources are released just before returning"
pattern naturally gives us that, which is very nice.
Will queue. Thanks.
prev parent reply other threads:[~2024-04-16 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:16 [PATCH] apply: avoid using fixed-size buffer in write_out_one_reject() René Scharfe
2024-04-16 22:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0f5c4q5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).