git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
	Chris Lasell <chrisl@pixar.com>
Subject: Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR
Date: Tue, 26 May 2015 13:21:01 -0700	[thread overview]
Message-ID: <xmqqpp5njdjm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <556199A2.8090802@diamand.org> (Luke Diamand's message of "Sun, 24 May 2015 10:28:02 +0100")

Luke Diamand <luke@diamand.org> writes:

> On 07/05/15 23:16, Junio C Hamano wrote:
>> Luke Diamand <luke@diamand.org> writes:
>>
>
> [Resurrecting old thread]
> ...
>
> To me, that seems to imply that for GIT_WINDOWS_NATIVE, we take the
> *second* branch and use "sh", so again, the the code as it stands will
> be fine. msysgit uses that path.
> ...
>
> I don't think we need to do anything. msysgit works fine with the
> origin "sh", "-c", ... code.

Thanks.  Let's merge what is in 'pu' down to 'next' then.

      reply	other threads:[~2015-05-26 20:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 17:24 [PATCH 0/2] Re: Bug: git-p4 edit_template() and P4EDITOR w/options Luke Diamand
2015-05-07 17:25 ` [PATCH 1/2] git-p4: add failing test for P4EDITOR handling Luke Diamand
2015-05-07 17:25 ` [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR Luke Diamand
2015-05-07 18:11   ` Junio C Hamano
2015-05-07 19:27     ` Luke Diamand
2015-05-07 20:16       ` Junio C Hamano
2015-05-07 20:42         ` Luke Diamand
2015-05-07 21:06           ` Junio C Hamano
2015-05-07 21:16             ` Junio C Hamano
2015-05-07 22:04               ` Luke Diamand
2015-05-07 22:16                 ` Junio C Hamano
2015-05-24  9:28                   ` Luke Diamand
2015-05-26 20:21                     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpp5njdjm.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=chrisl@pixar.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).